Remove the last screen and leave ScreenManager in a valid state #4111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def real_add_widget(self, screen, *args): | ||
| # ensure screen is removed from its previous parent | ||
| if screen.parent: | ||
| screen.parent.real_remove_widget(screen) |
There was a problem hiding this comment.
Since Screen can be added to any Widget not just ScreenManager, it's probably better to check if screen.parent is a ScreenManager instance and call remove_widget if it's not the case.
There was a problem hiding this comment.
Thanks, nice find! 👍
|
LGTM |
dessant
added a commit
that referenced
this pull request
Mar 21, 2016
Remove the last screen and leave ScreenManager in a valid state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4107 interferes with transitions, removing the current widget too soon, this pr fixes that.
clear_widgetsis also overridden to ensure proper cleaning, fixes #2655.