Add TextInput cursor blinking control #5455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeyWeeUsr
added
needs-unittest
Notes: API-break
|
Good to me, but you missed to document the change with .. versionchanged:: |
tito
added
the
awaiting-reply
KeyWeeUsr
changed the title
KeyWeeUsr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the original functionality of
cursor_blinkto_cursor_blink. Perhaps if we should preserve the "public" property, we might rename it to something more obvious such ascursor_invisibleor something similar."invisible" just because of the current behavior, otherwise we might invert it and use
cursor_visibleinstead.Closes #5449