Uix tabbedpanel #549
Merged
Uix tabbedpanel #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the default content container is now a FloatLayout instead of a GridLayout, for consistancy with other widgets.
| @@ -74,17 +75,13 @@ class ClosableHeader(TabbedPanelHeader): | |||
| size: self.parent.size | |||
| source: 'data/images/image-loading.gif' | |||
| StandingHeader: | |||
There was a problem hiding this comment.
I didn't seen it before, but if standing is standard, then... can you rename to DefaultHeader or BaseHeader / HeaderBase ? Check at others classname to see how the default classes are named
There was a problem hiding this comment.
The StandingHeader is the custom TabbedPanelHeader class defined in this example.
https://github.com/kivy/kivy/blob/uix-tabbedpanel/examples/widgets/tabbed_panel_showcase.py#L15
change it's type from StringProperty to ObjectProperty to be consistant with other widgets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current_tabproperty