Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core/camera]ensure floating point math when calculating fps #6032

Merged
merged 1 commit into from Oct 31, 2018
Merged

[core/camera]ensure floating point math when calculating fps #6032

merged 1 commit into from Oct 31, 2018

Conversation

seanodonnell
Copy link
Contributor

This corrects a bug in #6027 spotted by @pythonic64. Without this fps will by (wrongly) 0 on py27. @tito thanks for the merge, could you take a look at this too?

@seanodonnell seanodonnell mentioned this pull request Oct 31, 2018
Merged
@tshirtman tshirtman merged commit ad7ec53 into kivy:master Oct 31, 2018
AndreMiras
AndreMiras reviewed Oct 31, 2018
View reviewed changes
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it not be best to:

from __future__ import division

So we're covered for next time?

@matham matham changed the title ensure floating point math when calculating fps [core/camera]ensure floating point math when calculating fps May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMiras AndreMiras AndreMiras left review comments

@tshirtman tshirtman tshirtman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seanodonnell @tshirtman @AndreMiras