Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[input]Add caps and numlock to the modifiers #6286

Merged
merged 1 commit into from May 13, 2019
Merged

Conversation

matham
Copy link
Member

@matham matham commented May 3, 2019

Fixes #6285.

I looked at https://wiki.libsdl.org/SDL_Keymod and SDL_keycode.h and updated the code based on this.

Specifically,

  • I renamed the KMOD_xMETA key to KMOD_xGUI, because that's what sdl2 calls it (it's the key with the windows icon typically).
  • I added KMOD_MODE, this is basically the same as the right alt key.
  • I added the KMOD_NUM and KMOD_CAPS keys, which are the numslock and capslock keys.

@matham matham mentioned this pull request May 3, 2019
@matham matham merged commit 574887b into kivy:master May 13, 2019
@matham matham deleted the capslock branch May 13, 2019 19:07
@pythonic64
Copy link
Contributor

@matham Should Scroll Lock also be added to modifiers?

@matham
Copy link
Member Author

matham commented May 15, 2019

I didn't see it in the sdl2 list. I added most everything from their site.

But also, probably not as it is probably not used much? We can always add it later if someone does need it.

@pythonic64
Copy link
Contributor

I agree that it is not probably used much, but it would make modifiers list complete imho.
This issue #5062 is still present in current master ca3a68d.
Can you take a look at its pull request? Just asking because you knowledge of key handling.

@matham
Copy link
Member Author

matham commented May 18, 2019

I'm not really very familiar with the keyboard logic. Also, it'a not super clear to me how ready that PR is to be merged (for starters it has merge conflicts).

@matham matham changed the title Add caps and numlock to the modifiers [input]Add caps and numlock to the modifiers May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caps Lock not detected
2 participants