Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphics: Also set points _mode propery to LINE_MODE_POINTS #6777

Merged
merged 1 commit into from Mar 14, 2020
Merged

Graphics: Also set points _mode propery to LINE_MODE_POINTS #6777

merged 1 commit into from Mar 14, 2020

Conversation

salt-die
Copy link
Contributor

To be consistent with ellipse, circle, rectangle, rounded_rectangle, and bezier properties, the points property should change _mode to LINE_MODE_POINTS.

To be consistent with ellipse, circle, rectangle, rounded_rectangle, and bezier properties, the points property should change `_mode` to LINE_MODE_POINTS.
@welcome
Copy link

welcome bot commented Mar 14, 2020

Thanks for opening your first pull request here! 💖 Please check out our contributing guidelines.

Copy link
Member

@inclement inclement left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@matham matham merged commit 0b4c423 into kivy:master Mar 14, 2020
@welcome
Copy link

welcome bot commented Mar 14, 2020

Congrats on merging your first pull request! 🎉🎉🎉

@salt-die salt-die deleted the line_mode_bug branch March 14, 2020 19:38
@matham matham added this to the 2.0.0 milestone Oct 28, 2020
@matham matham changed the title points property sets _mode to LINE_MODE_POINTS Graphics: Also set points _mode propery to LINE_MODE_POINTS Dec 9, 2020
@matham matham added the Component: graphics kivy/graphics label Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: graphics kivy/graphics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants