Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: Warn that decorated methods might not be bindable. #7010

Merged
merged 4 commits into from Dec 10, 2020
Merged

Doc: Warn that decorated methods might not be bindable. #7010

merged 4 commits into from Dec 10, 2020

Conversation

Julian-O
Copy link
Contributor

This is the documentation-only part of #7007, and doesn't include improvements to exception messages to reinforce this message.

@Julian-O
#7007: Warn that decorated methods might not be bindable.
0b6bd67 
This is the documentation-only part of #7007, and doesn't include improvements to exception messages to reinforce this message.
@Julian-O
Improve description and mark-up
dd41d88
@Julian-O
Fix typo
0b5910f
@Julian-O
Copy link
Contributor Author

Now ready for review/merge. The failing PEP8 test is unrelated to my changes.

matham
matham requested changes Jul 22, 2020
View reviewed changes
Copy link
Member

@matham matham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it a little more succinct and remove reference to __name__ as that is too low-level.

kivy/_event.pyx Outdated Show resolved Hide resolved
kivy/_event.pyx Outdated Show resolved Hide resolved
kivy/_event.pyx Outdated Show resolved Hide resolved
@matham
Copy link
Member

matham commented Jul 22, 2020

Also, it would be nice if you add something similar to the docs of WeakMethod and maybe to https://github.com/kivy/kivy/blob/master/kivy/_event.pyx#L409.

@Zen-CODE
Copy link
Member

@Julian-O Any feedback on this? Thanks

@CastixGitHub
Copy link

Please merge this and add the additional commit to document also in WeakMethod and _event and changing the descriptions

@matham matham added this to the 2.1.0 milestone Dec 10, 2020
@matham matham changed the title #7007: Warn that decorated methods might not be bindable. Doc: Warn that decorated methods might not be bindable. Dec 10, 2020
@matham matham added the Component: documentation Documentation or examples label Dec 10, 2020
@matham matham merged commit 54c069d into kivy:master Dec 10, 2020
hamlet4401 pushed a commit to tytgatlieven/kivy that referenced this pull request Jul 3, 2021
@Julian-O @matham
Doc: Warn that decorated methods might not be bindable. (kivy#7010)
2dcc723 
* kivy#7007: Warn that decorated methods might not be bindable.

This is the documentation-only part of kivy#7007, and doesn't include improvements to exception messages to reinforce this message.

* Improve description and mark-up

* Fix typo

* Apply suggestions from code review

Co-authored-by: matham <moiein2000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matham matham matham requested changes

Assignees
No one assigned
Labels
Component: documentation Documentation or examples
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Julian-O @matham @Zen-CODE @CastixGitHub