Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image: Fix PIL label rendering shadow #7228

Merged
merged 1 commit into from Dec 10, 2020
Merged

Image: Fix PIL label rendering shadow #7228

merged 1 commit into from Dec 10, 2020

Conversation

onsunsl
Copy link
Contributor

@onsunsl onsunsl commented Nov 23, 2020 •
edited by matham

Remove the shadow caused by the background color difference of PIL font rendering

Before change

image

After chagne

image

Maintainer merge checklist

  • Title is descriptive/clear for inclusion in release notes.
  • Applied a Component: xxx label.
  • Applied the api-deprecation or api-break label.
  • Applied the release-highlight label to be highlighted in release notes.
  • Added to the milestone version it was merged into.
  • Unittests are included in PR.
  • Properly documented, including versionadded, versionchanged as needed.

@onsunsl
Fix PIL label rendering shadow
ca383e8 
Remove the shadow caused by the background color difference of PIL font rendering
@welcome
Copy link

welcome bot commented Nov 23, 2020

Thanks for opening your first pull request here! 💖 Please check out our contributing guidelines.

@matham matham changed the title Fix PIL label rendering shadow Image: Fix PIL label rendering shadow Dec 10, 2020
@matham matham added this to the 2.1.0 milestone Dec 10, 2020
matham
matham approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@matham matham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matham matham merged commit a35b053 into kivy:master Dec 10, 2020
@welcome
Copy link

welcome bot commented Dec 10, 2020

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matham matham matham approved these changes

Assignees
No one assigned
Labels
Component: core-providers kivy/core
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@onsunsl @matham