Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widget: fix export_to_png not passing arguments through #7322

Merged
merged 1 commit into from Jan 10, 2021
Merged

Widget: fix export_to_png not passing arguments through #7322

merged 1 commit into from Jan 10, 2021

Conversation

tshirtman
Copy link
Member

@tshirtman tshirtman commented Jan 10, 2021 •
edited by matham

This notably broke the scale parameter.

The test was passing because it didn't use assert or assertEqual but
simply ==.

fixes #7314

Maintainer merge checklist

  • Title is descriptive/clear for inclusion in release notes.
  • Applied a Component: xxx label.
  • Applied the api-deprecation or api-break label.
  • Applied the release-highlight label to be highlighted in release notes.
  • Added to the milestone version it was merged into.
  • Unittests are included in PR.
  • Properly documented, including versionadded, versionchanged as needed.

@tshirtman
Widget: fix export_to_png not passing arguments through
c2cb9b1 
This notably broke the scale parameter.

The test was passing because it didn't use `assert` or `assertEqual` but
simply `==.`

fixes #7314
@tshirtman tshirtman added the Component: Widgets kivy/uix, style.kv label Jan 10, 2021
@matham matham added this to the 2.1.0 milestone Jan 10, 2021
@matham matham merged commit ac30e71 into master Jan 10, 2021
@matham matham deleted the fix_7314 branch January 10, 2021 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matham matham matham approved these changes

Assignees
No one assigned
Labels
Component: Widgets kivy/uix, style.kv
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

export_to_png scale argument not working.
2 participants
@tshirtman @matham