Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabbedPanel: Doc calling switch_to from __init__ #7342

Merged
merged 3 commits into from Jan 24, 2021
Merged

TabbedPanel: Doc calling switch_to from __init__ #7342

merged 3 commits into from Jan 24, 2021

Conversation

andresbrocco
Copy link
Contributor

@andresbrocco andresbrocco commented Jan 23, 2021

Maintainer merge checklist

  • Title is descriptive/clear for inclusion in release notes.
  • Applied a Component: xxx label.
  • Applied the api-deprecation or api-break label.
  • Applied the release-highlight label to be highlighted in release notes.
  • Added to the milestone version it was merged into.
  • Unittests are included in PR.
  • Properly documented, including versionadded, versionchanged as needed.

Previous reference didn't link to anywhere, and now it links to the
dev-install page.
As discussed in the issue #3493, when calling this method from the
python script, it has to be scheduled to the next clock cycle.
@welcome
Copy link

welcome bot commented Jan 23, 2021

Thanks for opening your first pull request here! 💖 Please check out our contributing guidelines.

@andresbrocco
Copy link
Contributor Author

@matham , could you check if I did anything wrong? Why did the build fail? My changes were minimal

Copy link
Member

@matham matham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can ignore the failure. It happens sometimes and I'm not sure why.

kivy/uix/tabbedpanel.py Outdated Show resolved Hide resolved
@matham matham changed the title Doc update TabbedPanel: Doc calling switch_to from __init__ Jan 23, 2021
@matham matham added the Component: documentation Documentation or examples label Jan 23, 2021
@matham matham added this to the 2.1.0 milestone Jan 23, 2021
Co-authored-by: matham <moiein2000@gmail.com>
@matham matham merged commit a02efa3 into kivy:master Jan 24, 2021
@welcome
Copy link

welcome bot commented Jan 24, 2021

Congrats on merging your first pull request! 🎉🎉🎉

@andresbrocco andresbrocco deleted the doc_update branch January 24, 2021 15:24
hamlet4401 pushed a commit to tytgatlieven/kivy that referenced this pull request Jul 3, 2021
* Fixed reference

Previous reference didn't link to anywhere, and now it links to the
dev-install page.

* Added link for example usage

As discussed in the issue kivy#3493, when calling this method from the
python script, it has to be scheduled to the next clock cycle.

* Update kivy/uix/tabbedpanel.py

Co-authored-by: matham <moiein2000@gmail.com>

Co-authored-by: matham <moiein2000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: documentation Documentation or examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants