Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature: Allow control how many lines to scroll at once using the mouse wheel on TextInput #7626

Merged
merged 8 commits into from Mar 19, 2023

Conversation

DexerBR
Copy link
Contributor

@DexerBR DexerBR commented Sep 19, 2021

Currently vertical scrolling is limited to one line per scroll, and does not have an exposed option to control it. This PR allows you to scroll more than one line using a mouse wheel.
The number of rows scrolled at a time will default to 3.


Maintainer merge checklist

  • Title is descriptive/clear for inclusion in release notes.
  • Applied a Component: xxx label.
  • Applied the api-deprecation or api-break label.
  • Applied the release-highlight label to be highlighted in release notes.
  • Added to the milestone version it was merged into.
  • Unittests are included in PR.
  • Properly documented, including versionadded, versionchanged as needed.

@tshirtman
Copy link
Member

#7615 was merged :)

@DexerBR
Copy link
Contributor Author

DexerBR commented Sep 21, 2021

I changed the number of lines that scroll by default to 3, as it is more convenient, but this can be discussed.

@DexerBR DexerBR changed the title [WIP] Allows scrolling more than one line using the mouse scroll wheel Allow control how many lines to scroll at once using the mouse wheel Sep 21, 2021
tshirtman
tshirtman previously approved these changes Oct 14, 2021
Copy link
Member

@tshirtman tshirtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests are failing because of expecting the (now) wrong value, should be easy to fix.

@misl6
Copy link
Member

misl6 commented Nov 15, 2021

@DexerBR can you take care of the failing tests?

@misl6 misl6 added Component: Widgets kivy/uix, style.kv awaiting-reply Waiting for reply from issue opener, will be closed if no reply labels Nov 15, 2021
kivy/uix/textinput.py Outdated Show resolved Hide resolved
@DexerBR
Copy link
Contributor Author

DexerBR commented Jun 30, 2022

@misl6 Tests have been fixed!

@DexerBR DexerBR requested a review from tshirtman July 28, 2022 01:02
@misl6 misl6 removed the awaiting-reply Waiting for reply from issue opener, will be closed if no reply label Aug 25, 2022
@DexerBR DexerBR requested review from misl6 and removed request for tshirtman August 25, 2022 18:22
@DexerBR
Copy link
Contributor Author

DexerBR commented Nov 5, 2022

Hi @misl6 !
Is there anything else that needs to be addressed before merging this one?

@DexerBR DexerBR changed the title Allow control how many lines to scroll at once using the mouse wheel New Feature: Allow control how many lines to scroll at once using the mouse wheel on TextInput Dec 9, 2022
@DexerBR DexerBR requested review from tshirtman and misl6 and removed request for misl6 and tshirtman December 9, 2022 14:01
@misl6 misl6 added this to the 2.2.0 milestone Mar 19, 2023
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. And thank you for the heads up!

@misl6 misl6 merged commit e37e3b4 into kivy:master Mar 19, 2023
@DexerBR DexerBR deleted the textinput-feature1 branch March 19, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Widgets kivy/uix, style.kv
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants