New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Feature: Allow control how many lines to scroll at once using the mouse wheel on TextInput #7626
Conversation
#7615 was merged :) |
I changed the number of lines that scroll by default to 3, as it is more convenient, but this can be discussed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tests are failing because of expecting the (now) wrong value, should be easy to fix.
@DexerBR can you take care of the failing tests? |
@misl6 Tests have been fixed! |
Hi @misl6 ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. And thank you for the heads up!
Currently vertical scrolling is limited to one line per scroll, and does not have an exposed option to control it. This PR allows you to scroll more than one line using a mouse wheel.
The number of rows scrolled at a time will default to 3.
Maintainer merge checklist
Component: xxx
label.api-deprecation
orapi-break
label.release-highlight
label to be highlighted in release notes.versionadded
,versionchanged
as needed.