Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves docs on mobile, fixes duplicated getting started #7752

Merged
merged 1 commit into from Jan 20, 2022
Merged

Improves docs on mobile, fixes duplicated getting started #7752

merged 1 commit into from Jan 20, 2022

Conversation

misl6
Copy link
Member

@misl6 misl6 commented Jan 16, 2022

Maintainer merge checklist

  • Title is descriptive/clear for inclusion in release notes.
  • Applied a Component: xxx label.
  • Applied the api-deprecation or api-break label.
  • Applied the release-highlight label to be highlighted in release notes.
  • Added to the milestone version it was merged into.
  • Unittests are included in PR.
  • Properly documented, including versionadded, versionchanged as needed.

Considering that we should be near to a release, docs were asking for some love.

  • Fixed a duplicated Getting Started section in sidebar.
  • Improved CSS so documentation can be easily accessible via smartphone

@misl6 misl6 added the Type: Documentation Docs should be added/fixed label Jan 16, 2022
@misl6 misl6 changed the title Improves docs on mobile, fixes duplicated getting started [WIP] Improves docs on mobile, fixes duplicated getting started Jan 16, 2022
@misl6 misl6 force-pushed the feat/improve-docs-before-kivy2.1.0-release branch from 36cde45 to b79cd3c Compare January 16, 2022 09:48
@misl6 misl6 changed the title [WIP] Improves docs on mobile, fixes duplicated getting started Improves docs on mobile, fixes duplicated getting started Jan 16, 2022
@misl6 misl6 requested a review from AndreMiras January 16, 2022 14:13
@misl6 misl6 added this to the 2.1.0 milestone Jan 16, 2022
matham
matham approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@matham matham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at the generated docs in the artifacts and it looked great! I guess we'll see how it looks on mobile once generated.

@matham matham merged commit 29856d9 into kivy:master Jan 20, 2022
@misl6 misl6 added Component: documentation Documentation or examples and removed Type: Documentation Docs should be added/fixed labels Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matham matham matham approved these changes

@AndreMiras AndreMiras Awaiting requested review from AndreMiras

Assignees
No one assigned
Labels
Component: documentation Documentation or examples
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@misl6 @matham