Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linux AArch64 wheel build support #7769

Merged
merged 3 commits into from Jan 31, 2022
Merged

Conversation

odidev
Copy link
Contributor

@odidev odidev commented Jan 25, 2022

Closes #7670

Maintainer merge checklist

  • Title is descriptive/clear for inclusion in release notes.
  • Applied a Component: xxx label.
  • Applied the api-deprecation or api-break label.
  • Applied the release-highlight label to be highlighted in release notes.
  • Added to the milestone version it was merged into.
  • Unittests are included in PR.
  • Properly documented, including versionadded, versionchanged as needed.

@welcome
Copy link

welcome bot commented Jan 25, 2022

Thanks for opening your first pull request here! 💖 Please check out our contributing guidelines.

@misl6 misl6 changed the title Add Linux AArch64 wheel build support Add Linux AArch64 wheel build support [build wheel linux] Jan 25, 2022
@misl6
Copy link
Member

misl6 commented Jan 25, 2022

Hi @odidev,

I've added the [build wheel linux] tag into your PR title, so the CI can build linux wheels.
Feel free to add your optimisation commits, and let me know when you're ready for a review.
Would be nice to get it merged before Kivy 2.1.0 :)

@matham
Copy link
Member

matham commented Jan 25, 2022

Sadly, you can't edit the title to make it work, as explained here. You needed to originally open it with the build command in the title.

@misl6
Copy link
Member

misl6 commented Jan 25, 2022

Yep, reminded it after triggering the re-run ☹️

But, new commits, made to this PR, should be able to trigger the build.

@matham
Copy link
Member

matham commented Jan 26, 2022

But, new commits, made to this PR, should be able to trigger the build.

I'm not sure that the title will be changed though internally. I remember when testing it didn't work 😬

@misl6
Copy link
Member

misl6 commented Jan 30, 2022

But, new commits, made to this PR, should be able to trigger the build.

I'm not sure that the title will be changed though internally. I remember when testing it didn't work 😬

Uhm, I did it recently, multiple times and it worked.
But maybe I was making an improper use of a bug (When a bug is actually a feature 😂 ) .

@odidev Can you try to push a minor commit to see if the CI gives us a ✅ ?

Also, there's a specific reason to target ubuntu-18.04 ?

@matham matham added the Component: distribution Wheels, apt PPA, conda, end user install issues label Jan 30, 2022
@matham matham added this to the 2.1.0 milestone Jan 30, 2022
@matham
Copy link
Member

matham commented Jan 31, 2022

I changed the ubuntu version and it did make the wheels! Although I didn't change it everywhere, although probably should.

@matham matham changed the title Add Linux AArch64 wheel build support [build wheel linux] Add Linux AArch64 wheel build support Jan 31, 2022
@matham matham merged commit 270b4f4 into kivy:master Jan 31, 2022
@welcome
Copy link

welcome bot commented Jan 31, 2022

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: distribution Wheels, apt PPA, conda, end user install issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to release linux aarch64 wheels
3 participants