Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WindowBase: Update bind list of properties: system_size, size, width, height and center #7770

Conversation

pythonic64
Copy link
Contributor

@pythonic64 pythonic64 commented Jan 25, 2022

Changelog:

  • Removes softinput_mode and keyboard_height from bind lists to address 2284c2a#r33486046 comment
  • Adds _density to bind lists of width and height and removes it from center as center depends on width/height which makes dependency on _density implied
  • Not caching center because of width and height won't trigger caching in all cases.

Property center and caching problem: #6433

Maintainer merge checklist:

  • Title is descriptive/clear for inclusion in release notes.
  • Applied a Component: xxx label.
  • Applied the api-deprecation or api-break label.
  • Applied the release-highlight label to be highlighted in release notes.
  • Added to the milestone version it was merged into.
  • Unittests are included in PR.
  • Properly documented, including versionadded, versionchanged as needed.

@pythonic64 pythonic64 added this to the 2.1.0 milestone Jan 25, 2022
@matham matham merged commit fe1d9be into kivy:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants