Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix widget.disabled handling of value change of equal truthiness #7774

Merged
merged 1 commit into from Jan 29, 2022

Conversation

tshirtman
Copy link
Member

@tshirtman tshirtman commented Jan 29, 2022

Comparing for equality is too strict, when what we want is to know if
thue value is Truthy or Falsy, this mismatch in condition created cases
where a widget was set to disabled, but wasn't, as well as widgets
staying disabled, when they should have been enabled again.

Maintainer merge checklist

  • Title is descriptive/clear for inclusion in release notes.
  • Applied a Component: xxx label.
  • Applied the api-deprecation or api-break label.
  • Applied the release-highlight label to be highlighted in release notes.
  • Added to the milestone version it was merged into.
  • Unittests are included in PR.
  • Properly documented, including versionadded, versionchanged as needed.

Comparing for equality is too strict, when what we want is to know if
thue value is Truthy or Falsy, this mismatch in condition created cases
where a widget was set to disabled, but wasn't, as well as widgets
staying disabled, when they should have been enabled again.
@tshirtman tshirtman added the Component: core-widget properties, eventdispatcher, widget.py, animation label Jan 29, 2022
@tshirtman tshirtman added this to the 2.1.0 milestone Jan 29, 2022
@matham matham merged commit 315b742 into master Jan 29, 2022
@matham matham deleted the fix_disabled_truthyness branch January 29, 2022 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: core-widget properties, eventdispatcher, widget.py, animation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants