Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

made Generic Prompt unselectable #7801

Merged
merged 2 commits into from Feb 16, 2022
Merged

made Generic Prompt unselectable #7801

merged 2 commits into from Feb 16, 2022

Conversation

p0lygun
Copy link
Contributor

@p0lygun p0lygun commented Feb 12, 2022

Before

image

After

image
Maintainer merge checklist

  • Title is descriptive/clear for inclusion in release notes.
  • Applied a Component: xxx label.
  • Applied the api-deprecation or api-break label.
  • Applied the release-highlight label to be highlighted in release notes.
  • Added to the milestone version it was merged into.
  • Unittests are included in PR.
  • Properly documented, including versionadded, versionchanged as needed.

@p0lygun p0lygun changed the title made Generic Prompt unselectable; fixes #7800 made Generic Prompt unselectable Feb 12, 2022
@p0lygun
Copy link
Contributor Author

p0lygun commented Feb 15, 2022 •
edited

@misl6 why is macos unit test failing ?

@misl6
Copy link
Member

misl6 commented Feb 15, 2022

@misl6 why is macos unit test failing ?

Was unrelated to your PR. I did a re-run, so we will have a green check-mark here quite soon :)

Zen-CODE
Zen-CODE approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@Zen-CODE Zen-CODE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Works like a charm. Thanks ;-)

Note: Given that this is just a doc fix, the Maintainer Merge Checklist does nto really apply.

@Zen-CODE Zen-CODE merged commit 4d83ec5 into kivy:master Feb 16, 2022
@matham matham added the Component: documentation Documentation or examples label Feb 16, 2022
@matham matham added this to the 2.1.0 milestone Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zen-CODE Zen-CODE Zen-CODE approved these changes

Assignees
No one assigned
Labels
Component: documentation Documentation or examples
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@p0lygun @misl6 @Zen-CODE @matham