Fix VKeyboard missing with custom keyboard class #7846
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
window/__init__.py
the VKeyboard class is only imported when needed, which only happens inrequest_keyboard()
. If a custom keyboard class is set usingset_vkeyboard_class()
, it is never imported. In that case the function_get_kivy_vkheight()
that was introduced in #7726 fails, because VKeyboard is still None. This change instead compares toself._vkeyboard_cls
which is ensured above to not be None. If no custom class is set, this should still be just VKeyboard.Maintainer merge checklist
Component: xxx
label.api-deprecation
orapi-break
label.release-highlight
label to be highlighted in release notes.versionadded
,versionchanged
as needed.