#7978: Don't monkey-patch logging.root #7979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, move color terminal detection into its own function to reduce local complexity.
misl6
reviewed
Aug 27, 2022
There was a problem hiding this comment.
LGTM. Thank you!
However, I've added a suggestion, that could be nice to target before the merge.
Also, looks like I inadvertently found an issue introduced (I think, didn't check the blame history yet) by the previous changes. Will open an issue soon and ping you.
Its algorithm is more exhaustive than a simple env var check.
misl6
added
the
Component: core-app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer merge checklist
Component: xxxlabel.api-deprecationorapi-breaklabel.release-highlightlabel to be highlighted in release notes.versionadded,versionchangedas needed.