Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Platypus 5.4 #8006

Merged
merged 2 commits into from Oct 23, 2022
Merged

Use Platypus 5.4 #8006

merged 2 commits into from Oct 23, 2022

Conversation

akshayaurora
Copy link
Member

@akshayaurora akshayaurora commented Sep 12, 2022 •
edited by misl6

Maintainer merge checklist

  • Title is descriptive/clear for inclusion in release notes.
  • Applied a Component: xxx label.
  • Applied the api-deprecation or api-break label.
  • Applied the release-highlight label to be highlighted in release notes.
  • Added to the milestone version it was merged into.
  • Unittests are included in PR.
  • Properly documented, including versionadded, versionchanged as needed.

@misl6 misl6 changed the title Use Platypus 5.4 [build app osx] Use Platypus 5.4 Sep 12, 2022
@misl6
Copy link
Member

misl6 commented Sep 12, 2022

I was testing the same on my branch of kivy/kivy-sdk-packager 😄

I've added [build app osx] on the PR title, can you force push so we can test the produced .app ?

@misl6 misl6 added this to the 2.2.0 milestone Oct 5, 2022
@misl6
Copy link
Member

misl6 commented Oct 8, 2022

@akshayaurora ping 😄

@misl6 misl6 added the Component: distribution Wheels, apt PPA, conda, end user install issues label Oct 23, 2022
@misl6 misl6 changed the title [build app osx] Use Platypus 5.4 Use Platypus 5.4 Oct 23, 2022
@misl6
Copy link
Member

misl6 commented Oct 23, 2022

@akshayaurora FYI: I bumped it to 5.4.1 (released yesterday) and tested it on the CI.

Looks good!

Image 23-10-22 at 15 29

misl6
misl6 approved these changes Oct 23, 2022
View reviewed changes
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@misl6 misl6 merged commit 9cb0f0b into master Oct 23, 2022
@misl6 misl6 deleted the Platypus-5.4 branch October 23, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misl6 misl6 misl6 approved these changes

Assignees
No one assigned
Labels
Component: distribution Wheels, apt PPA, conda, end user install issues
Projects
Kivy's Control Tower
Status: Done
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akshayaurora @misl6