Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing Window.fullscreen and Window.borderless options after setup on iOS #8083

Merged
merged 3 commits into from Jan 9, 2023

Conversation

misl6
Copy link
Member

@misl6 misl6 commented Dec 26, 2022

Maintainer merge checklist

  • Title is descriptive/clear for inclusion in release notes.
  • Applied a Component: xxx label.
  • Applied the api-deprecation or api-break label.
  • Applied the release-highlight label to be highlighted in release notes.
  • Added to the milestone version it was merged into.
  • Unittests are included in PR.
  • Properly documented, including versionadded, versionchanged as needed.

As pointed out by a user on Discord, currently we did not allow to switch between fullscreen and windowed mode on iOS programmatically, but only during startup.

After some tests, looks like this is feasible and doesn't generate any unexpected behavior (like the issue described in #2710, referring to commit c80cbd8)

I've also added some extra docs, explaining how to show / hide the status bar, as fullscreen alone is not enough to control the status bar visibility.

Window.fullscreen = True and Window.borderless = True:

IMG_8091

Window.fullscreen = False and Window.borderless = False:

IMG_8093

@misl6 misl6 added this to the 2.2.0 milestone Dec 26, 2022
@misl6 misl6 assigned akshayaurora and unassigned akshayaurora Dec 30, 2022
@akshayaurora akshayaurora merged commit 17274a5 into kivy:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants