Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build wheel] Upgrade more GitHub Actions #8120

Merged
merged 1 commit into from Feb 4, 2023

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Feb 4, 2023

Maintainer merge checklist

  • Title is descriptive/clear for inclusion in release notes.
  • Applied a Component: xxx label.
  • Applied the api-deprecation or api-break label.
  • Applied the release-highlight label to be highlighted in release notes.
  • Added to the milestone version it was merged into.
  • Unittests are included in PR.
  • Properly documented, including versionadded, versionchanged as needed.

A broader application of the changes made in #8117. Dependabot, Renovate, etc. can automate most of these changes.

@misl6 misl6 changed the title Upgrade more GitHub Actions [build wheel] Upgrade more GitHub Actions Feb 4, 2023
@misl6
Copy link
Member

misl6 commented Feb 4, 2023

Hi @cclauss , I've added [build wheel] into title, so we can also test the wheel build, can you force push?

@misl6 misl6 added the Component: tests/CI Tests, CI, GitHub settings label Feb 4, 2023
@misl6 misl6 added this to the 2.2.0 milestone Feb 4, 2023
@cclauss
Copy link
Contributor Author

cclauss commented Feb 4, 2023

Force pushed https://github.com/kivy/kivy/pull/8120/commits

@cclauss
Copy link
Contributor Author

cclauss commented Feb 4, 2023

Several setup-python are hard coded to Python 3.9. Would it be better to use 3.x instead so that we are testing, building, etc. on the current Python (currently 3.11) so that the GitHub Actions catch incompatibilities before users do?

@misl6
Copy link
Member

misl6 commented Feb 4, 2023

Several setup-python are hard coded to Python 3.9. Would it be better to use 3.x instead so that we are testing, building, etc. on the current Python (currently 3.11) so that the GitHub Actions catch incompatibilities before users do?

We needed to force 3.9 in past (#7674), but there's no reason to stick to it right now.
So, yes, feel free to update our configuration accordingly. (But in a different PR)

Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (And CI is happy). Thank you!

@misl6 misl6 merged commit 62a0765 into kivy:master Feb 4, 2023
@cclauss cclauss deleted the upgrade-test-GitHub-actions branch February 4, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: tests/CI Tests, CI, GitHub settings
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants