Detect High DPI on Linux Desktop #8147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening your first pull request here! 💖 Please check out our contributing guidelines. |
akshayaurora
added
Component: graphics
akshayaurora
requested changes
Mar 6, 2023
| @@ -21,7 +21,7 @@ repos: | |||
| - id: pretty-format-json | |||
| args: | |||
| - --autofix | |||
| - repo: https://gitlab.com/pycqa/flake8 | |||
| - repo: https://github.com/pycqa/flake8 | |||
There was a problem hiding this comment.
This is a more generic change. Would you please do a separate pr for such changes.
Atomic prs that limit themself to just one specific topic are a boon.
There was a problem hiding this comment.
Sure, I will split it out into its own PR.
There was a problem hiding this comment.
Dropped this part from this PR now. Will check on the unit test failure.
jotoft
force-pushed
the
linux_highdpi_sdl2
branch
from
0b9aaf1
to
574bb57
Compare
If higher than normal DPI is configured using `KIVY_DPI` or other means then the density of the screen is higher and this should be reflected in the density. This will make the density calculation on linux the same as Windows and macOS. Unit test change: Use almost equal in density property unit tests Since the density is a floating point number, the tests can fail if the calculated value is slightly rounded.
Use [SDL_GetDisplayDPI](https://wiki.libsdl.org/SDL2/SDL_GetDisplayDPI) to get the display DPI if no high DPI was detected using the method described in the warning for the SDL_GetDisplayDPI function (which is the current method for guessing the DPI). If the X server is configured with the DPI of the display then this GetDisplayDPI method returns the correct DPI on Linux.
jotoft
force-pushed
the
linux_highdpi_sdl2
branch
from
574bb57
to
8e75624
Compare
|
Made the unit test tolerate a bit higher difference, that was what failed: Changed the tolerance to 1E-2 instead. They pass at 1E-3 here but realistically it is not really important that they have to be this accurate, and would rather be a bit lenient here to avoid confusion. |
akshayaurora
approved these changes
Mar 10, 2023
misl6
removed
Notes: Release-highlight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer merge checklist
Component: xxxlabel.api-deprecationorapi-breaklabel.release-highlightlabel to be highlighted in release notes.versionadded,versionchangedas needed.Before patch on Linux with high DPI
Scaling is not working unless setting the DPI and density manually using the environment variables
KIVY_DPIandKIVY_METRICS_DENSITY.After patch on Linux with high DPI
DPI is correctly set to the same as X11 is configured to.
Implementation
The DPI can be found using this SDL function SDL_GetDisplayDPI.
The warning suggests using another method, which is the one already used in
kivy/core/window/window_sdl2.pyThis other method I think only really works for macOS and IOS with retina displays.
So, if we are on a desktop and this method fails, then try to get the DPI using the SDL function and if that does not work we use the default of 96. Which will yield a density of 1.0 when density is calculated on Linux (with 74b866d) as well as the other desktop OSes.