New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Label
: allow different values of left, top, right and bottom for padding
.
#8162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the feature, a lot.
But, unfortunately, we should keep the padding_x
and padding_y
properties for a long time, and these properties can't be removed without having them deprecated first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @DexerBR !
The feature is great, and I really want to have it into 2.2.0 release, but we need to fix a few things regarding deprecations and migration paths.
I've left a few comments, which are trying to explain what needs to be done.
Feel free to ping me if you need any additional guidance.
Co-authored-by: Mirko Galimberti <me@mirkogalimberti.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
Previously,
padding
only accepted 2 values:[padding_horizontal, padding_vertical]
, now it has the same behavior aspadding
inBoxLayout
/GridLayout
:[10]
→[10, 10, 10, 10]
[10, 20]
→[10, 20, 10, 20]
[10, 20, 30, 40]
→[10, 20, 30, 40]
Test code:
Maintainer merge checklist
Component: xxx
label.api-deprecation
orapi-break
label.release-highlight
label to be highlighted in release notes.versionadded
,versionchanged
as needed.