Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy edits: Standardize on spelling #8308

Merged
merged 1 commit into from Jul 2, 2023
Merged

Conversation

Julian-O
Copy link
Contributor

@Julian-O Julian-O commented Jul 1, 2023

Changed comments (only) to use American spellings of common words.

(As an Australian, it hurts me to use the American spelling, but it looks more professional to have one standard throughout, and the code itself uses American spellings, so I kept it consistent.)

Also trivial copy-edits to comments in RecycleView.

Maintainer merge checklist

  • Title is descriptive/clear for inclusion in release notes.
  • Applied a Component: xxx label.
  • Applied the api-deprecation or api-break label.
  • Applied the release-highlight label to be highlighted in release notes.
  • Added to the milestone version it was merged into.
  • Unittests are included in PR.
  • Properly documented, including versionadded, versionchanged as needed.

Changed comments (only) to use American spellings of common words.

(As an Australian, it hurts me to use the American spelling, but it looks more professional to have one standard throughout, and the code itself uses American spellings, so I kept it consistent.)

Also trivial copy-edits to comments in RecycleView.
@Julian-O
Copy link
Contributor Author

Julian-O commented Jul 1, 2023

There were two locations in the code I didn't touch.

kivy/lib/vidcore_lite/egl.pyx defines an Initialise() function (which calls an initialize function).

kivy\modules\_webdebugger includes some JavaScript that checks for a value called "colour". I don't understand the code to know if that is right or wrong, so I assume it is right.

Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@misl6 misl6 merged commit c1d97f1 into kivy:master Jul 2, 2023
24 of 34 checks passed
@Julian-O Julian-O deleted the Standardizespelling branch July 2, 2023 10:14
@misl6 misl6 added the Component: documentation Documentation or examples label Jan 5, 2024
@misl6 misl6 added this to the 2.3.0 milestone Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: documentation Documentation or examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants