Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linux dependencies build instructions #8324

Merged

Conversation

jfishzon
Copy link
Contributor

@jfishzon jfishzon commented Jul 19, 2023

#8305
change from:
python -m virtualenv kivy_venv
to:
python -m venv kivy_venv

change from:
curl -O https://raw.githubusercontent.com/kivy/kivy/master/tools/build_linux_dependencies.sh -o build_kivy_deps.sh

to:
curl https://raw.githubusercontent.com/kivy/kivy/master/tools/build_linux_dependencies.sh -o build_kivy_deps.sh

change from:
https://virtualenv.pypa.io/en/latest/
to:
https://docs.python.org/3/library/venv.html

Maintainer merge checklist

  • Title is descriptive/clear for inclusion in release notes.
  • Applied a Component: xxx label.
  • Applied the api-deprecation or api-break label.
  • Applied the release-highlight label to be highlighted in release notes.
  • Added to the milestone version it was merged into.
  • Unittests are included in PR.
  • Properly documented, including versionadded, versionchanged as needed.

@welcome
Copy link

welcome bot commented Jul 19, 2023

Thanks for opening your first pull request here! 💖 Please check out our contributing guidelines.

Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jfishzon !

I've left a comment regarding a reference we have to virtualenv, can you please take care of it?

doc/sources/gettingstarted/installation.rst Show resolved Hide resolved
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@misl6 misl6 changed the title Docs: fix linux venv & build_kivy_deps.sh creation in docs as per issue 8305 Fix linux dependencies build instructions Jul 23, 2023
@misl6 misl6 added the Component: documentation Documentation or examples label Jul 23, 2023
@misl6 misl6 added this to the 2.3.0 milestone Jul 23, 2023
@misl6 misl6 merged commit d696932 into kivy:master Jul 23, 2023
34 checks passed
@welcome
Copy link

welcome bot commented Jul 23, 2023

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: documentation Documentation or examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants