Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Cython==3.x.x and increase cython_min version #8326

Merged
merged 2 commits into from Aug 26, 2023

Conversation

misl6
Copy link
Member

@misl6 misl6 commented Jul 22, 2023

Maintainer merge checklist

  • Title is descriptive/clear for inclusion in release notes.
  • Applied a Component: xxx label.
  • Applied the api-deprecation or api-break label.
  • Applied the release-highlight label to be highlighted in release notes.
  • Added to the milestone version it was merged into.
  • Unittests are included in PR.
  • Properly documented, including versionadded, versionchanged as needed.

馃煝 Everything has been tested on Cython==3.0.0 and Cython==0.29.36 on Apple Silicon (mac)
鈿狅笍 Let's see if there's something else to migrate for other platforms via CI

  • self.sources = args[1] raises an error with Cython==3.0.0 as sources is a kwarg instead, but that does not seem needed anymore.

  • cpdef can't be used for variables (and was not needed)

  • Cython==3.0.0 is less permissive with implicit casting

  • Increased cython_max to 3.0.0 and cython_min to 0.29.1 (previous Cython versions are not compatible with any of the currently supported Python versions)

@misl6 misl6 force-pushed the feat/cython-3.x.x-support branch from d3d7425 to 25b4aa0 Compare July 22, 2023 15:42
@misl6 misl6 requested a review from AndreMiras August 25, 2023 15:53
@misl6 misl6 added the Component: distribution Wheels, apt PPA, conda, end user install issues label Aug 26, 2023
@misl6 misl6 added this to the 2.3.0 milestone Aug 26, 2023
@misl6 misl6 merged commit ca1b918 into kivy:master Aug 26, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: distribution Wheels, apt PPA, conda, end user install issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants