Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjectProperty: Fixed ValueError message in "convert" method. #8349

Merged
merged 1 commit into from Aug 22, 2023

Conversation

DavidPesticcio
Copy link
Contributor

@DavidPesticcio DavidPesticcio commented Aug 14, 2023

Add space after ObjectProperty to improve readability of ValueError output.

Maintainer merge checklist

  • Title is descriptive/clear for inclusion in release notes.
  • Applied a Component: xxx label.
  • Applied the api-deprecation or api-break label.
  • Applied the release-highlight label to be highlighted in release notes.
  • Added to the milestone version it was merged into.
  • Unittests are included in PR.
  • Properly documented, including versionadded, versionchanged as needed.

@welcome
Copy link

welcome bot commented Aug 14, 2023

Thanks for opening your first pull request here! 💖 Please check out our contributing guidelines.

@pythonic64
Copy link
Contributor

Can you change title to: ObjectProperty: Fixed ValueError message in "convert" method?

@DavidPesticcio DavidPesticcio changed the title Add space after ObjectProperty to improve readability of ValueError output. ObjectProperty: Fixed ValueError message in "convert" method. Aug 16, 2023
@pythonic64 pythonic64 added the Component: documentation Documentation or examples label Aug 16, 2023
@pythonic64 pythonic64 added this to the 2.3.0 milestone Aug 16, 2023
@misl6 misl6 merged commit 48f42d9 into kivy:master Aug 22, 2023
32 of 34 checks passed
@welcome
Copy link

welcome bot commented Aug 22, 2023

Congrats on merging your first pull request! 🎉🎉🎉

@DavidPesticcio DavidPesticcio deleted the DavidPesticcio-patch-1-1 branch August 23, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: documentation Documentation or examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants