Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stencil operations when KIVY_WINDOW=x11 #8383

Merged
merged 1 commit into from Oct 10, 2023
Merged

Fix stencil operations when KIVY_WINDOW=x11 #8383

merged 1 commit into from Oct 10, 2023

Conversation

p32blo
Copy link
Contributor

@p32blo p32blo commented Sep 28, 2023 •
edited by misl6

Maintainer merge checklist

  • Title is descriptive/clear for inclusion in release notes.
  • Applied a Component: xxx label.
  • Applied the api-deprecation or api-break label.
  • Applied the release-highlight label to be highlighted in release notes.
  • Added to the milestone version it was merged into.
  • Unittests are included in PR.
  • Properly documented, including versionadded, versionchanged as needed.

This PR fixes this issue:

I was able to compile kivy and see that the proposed solution worked.

@welcome
Copy link

welcome bot commented Sep 28, 2023

Thanks for opening your first pull request here! 💖 Please check out our contributing guidelines.

@misl6 misl6 changed the title Fix stencil operations on x11 Fix stencil operations when KIVY_WINDOW=x11 Oct 10, 2023
@misl6 misl6 added the Component: core-app app, clock, config, inspector, logger, resources, modules, clock, base.py label Oct 10, 2023
@misl6 misl6 added this to the 2.3.0 milestone Oct 10, 2023
misl6
misl6 approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works like a charm.

LGTM. Thank you!

@misl6 misl6 merged commit 23376f3 into kivy:master Oct 10, 2023
34 checks passed
@welcome
Copy link

welcome bot commented Oct 10, 2023

Congrats on merging your first pull request! 🎉🎉🎉

@misl6 misl6 mentioned this pull request Oct 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misl6 misl6 misl6 approved these changes

Assignees
No one assigned
Labels
Component: core-app app, clock, config, inspector, logger, resources, modules, clock, base.py
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@p32blo @misl6