Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose new clear_stencil property in StencilPush #8413

Merged
merged 3 commits into from Oct 27, 2023
Merged

Expose new clear_stencil property in StencilPush #8413

merged 3 commits into from Oct 27, 2023

Conversation

DexerBR
Copy link
Contributor

@DexerBR DexerBR commented Oct 20, 2023 •
edited by misl6

clear_stencil was introduced here but could not be modified after instantiation, nor could it be declared in the kvlang; this PR exposes this property.

Maintainer merge checklist

  • Title is descriptive/clear for inclusion in release notes.
  • Applied a Component: xxx label.
  • Applied the api-deprecation or api-break label.
  • Applied the release-highlight label to be highlighted in release notes.
  • Added to the milestone version it was merged into.
  • Unittests are included in PR.
  • Properly documented, including versionadded, versionchanged as needed.

@misl6 misl6 added this to the 2.3.0 milestone Oct 25, 2023
@misl6 misl6 added the Component: graphics kivy/graphics label Oct 25, 2023
@misl6 misl6 self-assigned this Oct 25, 2023
misl6
misl6 approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@misl6 misl6 merged commit 7fd2f37 into kivy:master Oct 27, 2023
34 checks passed
@DexerBR DexerBR deleted the clear_stencil_expose branch October 28, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misl6 misl6 misl6 approved these changes

Assignees

@misl6 misl6

Labels
Component: graphics kivy/graphics
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DexerBR @misl6