Fixes markup [sup]
followed by [sub]
doesn't work (issue #8077)
#8435
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes to
markup.py
to fix #8077Fix was to add a condition
wh < pph
to the logic used to calculatescript_pos
for sub-/superscript inrender_lines
method. This means the "if condition" is only evaluated when nested, otherwise the "else condition" is evaluated and used in the calculation.Tested with the following file, which builds on the test script in the original issue report:
Issue8077_test.zip
Output display, showing multiple variations of sub and sup, including nested conditions:
Please let me know if there are any other tests I should run (I did not see anything in the documentation), additional changes that need to be make, or if I should make the pull request against a different branch.
Maintainer merge checklist
Component: xxx
label.api-deprecation
orapi-break
label.release-highlight
label to be highlighted in release notes.versionadded
,versionchanged
as needed.