Refactor filechoosertest_unicode.py
#8485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was thinking about making changes to filechooser.py, but was not happy with the state of the existing tests. This refactor includes: * Moving imports to the top of the file. * Removing unused imports. Importing names the same way. * Importing platform from where it is defined in `kivy.utils`, rather than `kivy` where it is explicitly not exported. * Continue to skip the tests on some platforms, but use `pytest.mark.skipif` to do so, so pytest knows it has been skipped. * Copy-edit comment * bfile testing was only doing anything on Python 2. Removed. * Renamed variables to be more meaningful now there is not unicode versus bytes. * Ran through `black` so the formatting is neater. * Removed spurious `for i in range(1):` * Corrected misspelling `exitsfiles` * Specified exceptions to ignore. * Simplified deletion, and made it more robust - one file failure won't stop rest being deleted. [There was no attempt to improve coverage here - filechooser.py is over 1,000 lines long, and is embarrassingly undertested.]
misl6
changed the title
filechoosertest_unicode.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was thinking about making changes to filechooser.py, but was not happy with the state of the existing tests.
This refactor includes:
platformfrom where it is defined inkivy.utils, rather thankivywhere it is explicitly not exported.pytest.mark.skipifto do so, so pytest knows it has been skipped.blackso the formatting is neater.for i in range(1):exitsfiles[There was no attempt to improve coverage here - filechooser.py is over 1,000 lines long, and is embarrassingly undertested.]
Maintainer merge checklist
Component: xxxlabel.api-deprecationorapi-breaklabel.release-highlightlabel to be highlighted in release notes.versionadded,versionchangedas needed.