Made ImageLoader.zip_loader skip loaders that raised an error or returned None. #985
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason one of the image loaders was failing on Mac OS X. Running the widgets/sequence_images example:
However, wrapping the:
in
try...except
was not enough.Sometimes there was an image not recognized by any loader. (e.g. an artefact from the zip program while performing the zipping), and if that artefact turns out to be the last file attempted to be loaded,
im
in:would be
None
, causing an AttributeError.So I've had to change it to use another variable
image
to keep track of the last image successfully loaded. It is only assigned whenim
returned from the loader is notNone
.