Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2019.06.06 #1839

Merged
merged 4 commits into from
Jun 8, 2019
Merged

Release 2019.06.06 #1839

merged 4 commits into from
Jun 8, 2019

Conversation

inclement
Copy link
Member

@inclement inclement commented Jun 6, 2019

I've set up the master/develop repository structure, now working to make a first release.

I'm including in this release branch whatever final changes I've found we need to make the develop branch the default. Per procedure, these will of course be merged back into develop as well as master. Let me know if you see anything I've missed.

This is probably last call on the release numbering system. Do we want any suffix, like 20190606.1?

Release checklist

  • Check that the build is passing

  • Run the tests locally via tox: this performs some long-running tests that are skipped on Travis.

  • Build and run the on_device_unit_tests app using buildozer. Check that they all pass.

  • Build and run the following testapps for arch armeabi-v7a and arm64-v8a:

    • python3 setup_testapp_python3_sqlite_openssl.py apk
      • armeabi-v7a
      • arm64-v8a
    • python3 setup_testapp_python2.py apk
      • armeabi-v7a
      • arm64-v8a
  • Check that the version number is correct

@inclement inclement requested review from AndreMiras, a user and opacam June 6, 2019 20:35
@inclement inclement added the WIP label Jun 6, 2019
AndreMiras
AndreMiras previously approved these changes Jun 6, 2019
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inclement
Copy link
Member Author

I've redirected all existing pull requests from master to the develop branch.

@AndreMiras
Copy link
Member

As for the suffix that's only needed if we do two releases in one day right? Well if we ever need it then yes we could YYYY.MM.DD.PATCH, but I usually simply YYYY.MM.DD+1 to keep the format consistent

@inclement
Copy link
Member Author

Just wondering, does travis provide a way to upload build artifacts somewhere? It would be nice if we could test the APKs built automatically, even if that testing is not itself automatic yet.

@AndreMiras
Copy link
Member

Yes it does but I've never played with it

AndreMiras
AndreMiras previously approved these changes Jun 7, 2019
@AndreMiras
Copy link
Member

By the way, now I'm thinking how do we want to handle the .. versionchanged:: parts? It probably means on develop this string will be incomplete because we don't know the version upfront. Then we can review/fill these incomplete strings while preparing the release branch

@opacam
Copy link
Member

opacam commented Jun 7, 2019

Maybe we should change from master to develop this line:

def modified_recipes(branch='origin/master'):

At: https://github.com/kivy/python-for-android/blob/develop/ci/rebuild_updated_recipes.py#L34

@inclement
Copy link
Member Author

I'm thinking that on the develop branch we should use version YYYY.MM.DD.1.dev0, where the YYYY.MM.DD comes from the latest release version. That should mean that pip orders the version correctly. We would expect that the next release would not actually be YYYY.MM.DD.1, it's just a convenient way to mark correctly that the develop branch is newer than the master branch. Any objections to taht?

@AndreMiras
Copy link
Member

That makes total sense 👍

@inclement
Copy link
Member Author

Thanks @opacam, fixed that reference.
As far as I'm concerned this is good to go, I'll merge it as soon as someone approves it again.

Copy link
Member

@opacam opacam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@inclement inclement merged commit ec547bb into master Jun 8, 2019
@inclement inclement removed the WIP label Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants