Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twisted recipe #2147

Merged
merged 1 commit into from Apr 21, 2020
Merged

Twisted recipe #2147

merged 1 commit into from Apr 21, 2020

Conversation

pavelsof
Copy link
Contributor

Update of the recipe for Twisted so that it removes the unit tests in the prebuild_arch hook. This should decrease the size from 11 down to 4 MB for the uncompressed APK directory.

AndreMiras
AndreMiras approved these changes Apr 21, 2020
View reviewed changes
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not sure why it's not dealt with upstream

@AndreMiras AndreMiras merged commit 3aa2aec into kivy:develop Apr 21, 2020
@AndreMiras
Copy link
Member

Thanks for the fix. I've edited the commit message for slightly more explicit.
Out of curiosity, is there a bug report upstream and what's the stance of them regarding it?

@pavelsof
Copy link
Contributor Author

Thank you!

I looked around a bit, but I cannot find a ticket about this in Twisted's tracker or any info about whether they actually have an opinion or this is just how their directory structure happened to be :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMiras AndreMiras AndreMiras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pavelsof @AndreMiras