added support for include xml elements inside <manifest><application> AndroidManifest.xml #2691

dvjdjvu · 2022-10-21T14:59:38Z

My changes affect builddozer and python-for-kivy.

I added support for add rules for autostart. Now you can use section in buildozer.spec:

android.extra_manifest_application = %(source.dir)s/xml/receivers.xml

1 updated android.extra_manifest_application to android.extra_manifest_application_entry (see below)
2 updated android.extra_manifest_application_entry to android.extra_manifest_application_xml (see below)

for add rules in AndroidManifest.xml for autostart:

<receiver android:name=".MyBroadcastReceiver" android:enabled="true" android:exported="true">
    <intent-filter>
        <action android:name="android.intent.action.BOOT_COMPLETED" />
        <action android:name="android.intent.action.QUICKBOOT_POWERON" />
        <action android:name="com.htc.intent.action.QUICKBOOT_POWERON" />
    </intent-filter>
</receiver>

This is article doesn't work Starting Kivy App and Service on bootup on Android

lufebe16

Looks o.k. but ...
There is no appropriate entry in tests/test_build.py. Does it really work?

lufebe16 · 2022-12-13T20:56:01Z

Went from a deeper test of these changes.

Related changes in buildozer work correctly. But in python-for-android (here) a problem exists with the name of the entry. It was surprising to see, that the new entry was accepted by p4a even before any adaptations have been done.

After application of the proposed changes to p4a nothing changed. The new entry was accepted, but ignored.

The problem seems to be the name. Because its a substring of another option. This might be a bug somwhere in p4a or maybe in the argument parsing library used.

After replaceing 'extra-manifest-application' to 'extra-manifest-application-entry' all over buildozer and p4a the change will work.

dvjdjvu · 2022-12-14T12:53:05Z

The problem seems to be the name. Because its a substring of another option. This might be a bug somwhere in p4a or maybe in the argument parsing library used.

Yes, when I did test project (article, git), I got this problem, but when I do this decide local, everything work.

After replaceing 'extra-manifest-application' to 'extra-manifest-application-entry' all over buildozer and p4a the change will work.

I think this way true. I will change code.

dvjdjvu · 2022-12-14T13:52:26Z

I did it. Updated to "extra-manifest-application-entry".

lufebe16

requested changes have been applied. So this will be o.k.

Duke0425 · 2023-01-19T06:23:32Z

May I ask when these changes will be merged, I also encountered these problems. My project needs to reset the buildozer package every time, which makes it troublesome for me to modify its source code

dvjdjvu · 2023-01-19T10:54:52Z

I don't know. Somebody who have accesses must approve merge pull request.

Duke0425 · 2023-02-02T06:12:07Z

I don't know. Somebody who have accesses must approve merge pull request.

@tshirtman @matham If the modification is correct, can it be merged into? Please click approve, I am still modifying the library code during development, which makes me a headache

js-teevee · 2023-02-13T17:14:48Z

can we get an update on this please? these changes will allow for starting on boot and restarting when reinstalled etc. the java/android hooks are necessary. this will take kivy/python-for-android to the next level and allow python apps/services to better hook into android.

misl6

HI @dvjdjvu !

I'm sorry for the late reply. I've left some comments.

Feel free to ping me when you're ready for a review.

misl6 · 2023-02-13T21:10:43Z

pythonforandroid/bootstraps/common/build/build.py

@@ -851,6 +851,9 @@ def parse_args_and_make_package(args=None):
    ap.add_argument('--extra-manifest-xml', default='',
                    help=('Extra xml to write directly inside the <manifest> element of'
                          'AndroidManifest.xml'))
+    ap.add_argument('--extra-manifest-application-entry', default='',


Can we rename --extra-manifest-application-entry to --extra-manifest-application-xml, since it adds some extra XML into <manifest><application>?

Yes we can.

misl6 · 2023-02-13T21:11:36Z

pythonforandroid/bootstraps/sdl2/build/templates/AndroidManifest.tmpl.xml

@@ -63,6 +63,9 @@
                 android:theme="{{args.android_apptheme}}{% if not args.window %}.Fullscreen{% endif %}"
                 android:hardwareAccelerated="true"
                 android:extractNativeLibs="true" >
+
+        {{ args.extra_manifest_application_entry }}


We should add this snippet to all the supported bootstraps.

In service_library, service_only and webview not need.

@dvjdjvu please do not resolve conversations, unless it's quite clear that are resolved.

Why this is not needed on webview, service_library and service_only ?

I did not know what these things were for, now I have studied a little. I think you are right, it should be added.

dvjdjvu · 2023-02-16T11:40:21Z

Hi @misl6. I did the review.

dvjdjvu · 2023-02-16T11:58:31Z

And I added choice type start service START_STICKY, START_NOT_STICKY and START_REDELIVER_INTENT.
Default use now and before START_NOT_STICKY, but when you close app, service close too.

And I used this code for restart service.

PythonService = autoclass('org.kivy.android.PythonService')
PythonService.mService.setAutoRestartService(True)

Now you can use

PythonService.mService.setTypeStartSticky()
PythonService.mService.setTypeStartNotSticky()
PythonService.mService.setTypeStartRedeliverIntent()

With setTypeStartNotSticky, service doesnt close when app swipping or close.

misl6 · 2023-02-16T21:36:27Z

@dvjdjvu
Can we keep the additions (START_STICKY/START_NOT_STICKY/START_REDELIVER_INTENT) into a different PR?

Feel free to ping me when you're ready with the review!

dvjdjvu · 2023-02-17T13:10:53Z

Ok @misl6. You can merge this pull request and close it. I won't do anything else here. I removed the changes START_STICKY from here. We need to close this section.

I will open new pull request for START_STICKY/START_NOT_STICKY/START_REDELIVER_INTENT.

misl6

I've left a comment requesting more info, as I think this feature should also be added to other bootstraps, and not only sdl2.

Also, please add your feature to the python-for-android documentation: https://github.com/kivy/python-for-android/tree/develop/doc/source

dvjdjvu · 2023-02-20T12:04:34Z

Hi @misl6, I did everythings. I hope.

dvjdjvu · 2023-05-11T15:50:50Z

Hello @misl6, you did update? Please do it.
(I updated my project, and all edits are gone :(( )

CristianPi · 2023-06-30T22:34:23Z

any news? this is blocking

dvjdjvu · 2023-09-25T15:34:10Z

@misl6 @lufebe16 @js-teevee, I updated the PR to the latest versions of the source code.

kwuite · 2023-10-01T22:03:48Z

@dvjdjvu I found your article today while learning Kivy and researching how to build a service that can keep running when the app closes or the phone is restarted. Thanks for the work you put out there!

I was able to build and deploy your code to my docker-android container and pushed my logic to a fork from kivy_service_test. Hopefully this can help people to use your logic untill they merge it.

If you want I can do a PR to your repo. Here is my fork that can help out by installing your python-for-android and buildozer fork via git with poetry:

colebrooks · 2024-03-26T22:57:19Z

So is this completely dead? I just ran into the need to register a receiver in the manifest, and manually editing the template doesn't feel like a very robust or portable solution. Given the other facilities in buildozer to mutate the generated manifest, I'm surprised this functionality hasn't been merged yet/wasn't just included from the beginning.

This was referenced Oct 21, 2022

added support for include xml elements inside <manifest><application> AndroidManifest.xml kivy/buildozer#1519

Open

Add rule receiver in AndroidManifest.xml kivy/buildozer#1518

Open

lufebe16 reviewed Dec 13, 2022

View reviewed changes

lufebe16 previously approved these changes Dec 14, 2022

View reviewed changes

js-teevee previously approved these changes Feb 13, 2023

View reviewed changes

misl6 requested changes Feb 13, 2023

View reviewed changes

dvjdjvu dismissed stale reviews from js-teevee and lufebe16 via f5f6e7c February 15, 2023 16:54

dvjdjvu force-pushed the develop branch from 6c14c1c to f5f6e7c Compare February 17, 2023 13:00

misl6 requested changes Feb 18, 2023

View reviewed changes

dvjdjvu force-pushed the develop branch from d8b41d7 to f5f6e7c Compare February 18, 2023 11:01

dvjdjvu force-pushed the develop branch from 161c7c1 to c6d39ad Compare September 23, 2023 13:23

Adding support for including XML elements within <manifest><application>

469c19f

dvjdjvu force-pushed the develop branch from 6114467 to 469c19f Compare September 25, 2023 15:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added support for include xml elements inside <manifest><application> AndroidManifest.xml #2691

added support for include xml elements inside <manifest><application> AndroidManifest.xml #2691

dvjdjvu commented Oct 21, 2022 •

edited

lufebe16 left a comment

lufebe16 commented Dec 13, 2022

dvjdjvu commented Dec 14, 2022

dvjdjvu commented Dec 14, 2022

lufebe16 left a comment

Duke0425 commented Jan 19, 2023

dvjdjvu commented Jan 19, 2023

Duke0425 commented Feb 2, 2023

js-teevee commented Feb 13, 2023

misl6 left a comment

misl6 Feb 13, 2023 •

edited

dvjdjvu Feb 15, 2023 •

edited

misl6 Feb 13, 2023

dvjdjvu Feb 15, 2023 •

edited

misl6 Feb 18, 2023

dvjdjvu Feb 20, 2023

dvjdjvu commented Feb 16, 2023

dvjdjvu commented Feb 16, 2023 •

edited

misl6 commented Feb 16, 2023

dvjdjvu commented Feb 17, 2023 •

edited

misl6 left a comment

dvjdjvu commented Feb 20, 2023

dvjdjvu commented May 11, 2023

CristianPi commented Jun 30, 2023

dvjdjvu commented Sep 25, 2023 •

edited

kwuite commented Oct 1, 2023

colebrooks commented Mar 26, 2024

added support for include xml elements inside <manifest><application> AndroidManifest.xml #2691

Are you sure you want to change the base?

added support for include xml elements inside <manifest><application> AndroidManifest.xml #2691

Conversation

dvjdjvu commented Oct 21, 2022 • edited

lufebe16 left a comment

Choose a reason for hiding this comment

lufebe16 commented Dec 13, 2022

dvjdjvu commented Dec 14, 2022

dvjdjvu commented Dec 14, 2022

lufebe16 left a comment

Choose a reason for hiding this comment

Duke0425 commented Jan 19, 2023

dvjdjvu commented Jan 19, 2023

Duke0425 commented Feb 2, 2023

js-teevee commented Feb 13, 2023

misl6 left a comment

Choose a reason for hiding this comment

misl6 Feb 13, 2023 • edited

Choose a reason for hiding this comment

dvjdjvu Feb 15, 2023 • edited

Choose a reason for hiding this comment

misl6 Feb 13, 2023

Choose a reason for hiding this comment

dvjdjvu Feb 15, 2023 • edited

Choose a reason for hiding this comment

misl6 Feb 18, 2023

Choose a reason for hiding this comment

dvjdjvu Feb 20, 2023

Choose a reason for hiding this comment

dvjdjvu commented Feb 16, 2023

dvjdjvu commented Feb 16, 2023 • edited

misl6 commented Feb 16, 2023

dvjdjvu commented Feb 17, 2023 • edited

misl6 left a comment

Choose a reason for hiding this comment

dvjdjvu commented Feb 20, 2023

dvjdjvu commented May 11, 2023

CristianPi commented Jun 30, 2023

dvjdjvu commented Sep 25, 2023 • edited

kwuite commented Oct 1, 2023

colebrooks commented Mar 26, 2024

dvjdjvu commented Oct 21, 2022 •

edited

misl6 Feb 13, 2023 •

edited

dvjdjvu Feb 15, 2023 •

edited

dvjdjvu Feb 15, 2023 •

edited

dvjdjvu commented Feb 16, 2023 •

edited

dvjdjvu commented Feb 17, 2023 •

edited

dvjdjvu commented Sep 25, 2023 •

edited