New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recipes: Introduce RustCompiledComponentsRecipe
, add pydantic-core
and update cryptography
#2962
Conversation
@Julian-O Hi, can you please triggre CI? |
Sorry, I don't have permissions for that. @misl6? |
Interesting approach, thanks for looking this up.
See here https://github.com/kivy/python-for-android/actions/runs/7658579349 |
a4773bc
to
024fad9
Compare
024fad9
to
06295d8
Compare
54ac6f4
to
b2182e1
Compare
Build works, please somebody cancel all the previous actions triggred except the latest one. |
@T-Dynamos FYI, Unit tests are failing. Regarding the approach, there's something that will be repetitive along all the upcoming recipes for rust-backed libraries? |
It's good idea. As |
Do not take it as a "we should do it like that", feel free to improve the thinking. Please also remind to add the new dependency into |
pydantic-core
recipeRustCompiledComponentsRecipe
, add pydantic-core
and update cryptography
c9abff8
to
24706b4
Compare
@misl6 Done!, After review I will document all. |
@T-Dynamos can you please rebase on top of |
7c812e9
to
ef829d5
Compare
@misl6 CI looks happy now. |
Looks like we have a failure on 3 jobs with almost the same issue:
Can you make sure you have rebased on top of latest I'm wondering if the |
Yes |
b129f20
to
26a5415
Compare
@misl6 Done! 🔥 . |
@misl6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a comment regarding a specific change.
No need to make changes, but I only need an explanation ATM.
Regarding the numpy
fix: Hacky, but it works, and I'm fine with it.
Hopefully PEP738 will help us to clean python-for-android
from these hacks and perform isolated builds as 1,2,3 ... (so let's keep an eye on the progress).
ed61368
to
ec74c5f
Compare
@misl6 Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait for the CI/CD pipeline to complete, but LGTM
…` and update `cryptography`
Sorry had to do one last change, please cancel other actions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait to the CI/CD pipeline to complete, but LGTM.
Closes #2661 #2955
Surpasses #2957
CC: @AndreMiras @misl6 Is approach used here is fine?