Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mock assertion in ICU recipe #3003

Merged
merged 1 commit into from Apr 9, 2024
Merged

Fix mock assertion in ICU recipe #3003

merged 1 commit into from Apr 9, 2024

Conversation

s-t-e-v-e-n-k
Copy link
Contributor

@s-t-e-v-e-n-k s-t-e-v-e-n-k commented Apr 9, 2024 •
edited

Python 3.12 now does not blindly call any methods on mocked objects, which masks issues. Correct the assertion of has_calls to assert_has_calls in the ICU recipe.

Fixes #3002

@s-t-e-v-e-n-k
Fix mock assertion in ICU recipe
5d5ca2b 
Python 3.12 now does not blindly any methods on mocked objects, which
masks issues. Correct the assertion of has_calls to assert_has_calls in
the ICU recipe.

Fixes kivy#3002
AndreMiras
AndreMiras approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix and comprehensive commit message

@AndreMiras AndreMiras merged commit db4e736 into kivy:develop Apr 9, 2024
29 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMiras AndreMiras AndreMiras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mock assertion issue with ICU recipe under Python 3.12
2 participants
@s-t-e-v-e-n-k @AndreMiras