Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recipe: introduce isolated builds, using PyProjectRecipe #3007

Merged
merged 1 commit into from May 9, 2024
Merged

recipe: introduce isolated builds, using PyProjectRecipe #3007

merged 1 commit into from May 9, 2024

Conversation

T-Dynamos
Copy link
Contributor

@T-Dynamos T-Dynamos commented Apr 20, 2024 •
edited

Closes #2904, Closes #2776 and maybe more

  • PyProjectRecipe: support for building packages in isolation which don't have setup.py file but pyproject.toml.
  • MesonRecipe: support for cross compiling meson based packages.

Here we need to inform the p4a users that if they are using numpy, they to set minimum ndk api to 24.

@T-Dynamos T-Dynamos force-pushed the pandas-update branch 4 times, most recently from 0106e5c to ec37a4d Compare April 21, 2024 07:14
@T-Dynamos T-Dynamos changed the title [WIP]: recipe: introduce PyProjectRecipe and MesonRecipe recipe: introduce PyProjectRecipe and MesonRecipe Apr 21, 2024
@T-Dynamos T-Dynamos force-pushed the pandas-update branch 2 times, most recently from 0e6c0a5 to bd3c5b1 Compare April 21, 2024 07:57
@misl6
Copy link
Member

misl6 commented Apr 21, 2024

Please ping me when you're ready

What is gonna be promising is the PyProjectRecipe, as we still rely on setup.py and non-isolated builds.

Moving to isolated builds will help us quite a lot to mitigate most of the issues that currently require a lot of hacks/setup from the user side (Incompatible Cython versions, etc ...)

@T-Dynamos T-Dynamos changed the title recipe: introduce PyProjectRecipe and MesonRecipe recipe: introduce isolated builds, using PyProjectRecipe Apr 22, 2024
@T-Dynamos
Copy link
Contributor Author

T-Dynamos commented Apr 22, 2024 •
edited

@misl6 Hi, I can't figure out how to bump min ndk_api version. Can you please figure out?

Edit: NVM fixed.

@T-Dynamos T-Dynamos force-pushed the pandas-update branch 11 times, most recently from 2e9bcc3 to 0248fca Compare April 28, 2024 07:34
@T-Dynamos T-Dynamos force-pushed the pandas-update branch 3 times, most recently from 2a2213c to 8fd49b2 Compare April 30, 2024 12:58
@T-Dynamos T-Dynamos marked this pull request as ready for review April 30, 2024 13:00
@T-Dynamos T-Dynamos force-pushed the pandas-update branch 2 times, most recently from 56f8bfb to 2ac6d8e Compare April 30, 2024 13:22
@T-Dynamos T-Dynamos marked this pull request as draft April 30, 2024 13:24
@T-Dynamos T-Dynamos force-pushed the pandas-update branch 4 times, most recently from 9c2e2ea to d8c7488 Compare May 2, 2024 15:57
@T-Dynamos T-Dynamos marked this pull request as ready for review May 2, 2024 15:59
@T-Dynamos
Copy link
Contributor Author

T-Dynamos commented May 2, 2024 •
edited

@misl6 As now we are building wheels for packages, is there any plan to host that wheels? This could save some compile time.

@misl6
Copy link
Member

misl6 commented May 4, 2024

@misl6 As now we are building wheels for packages, is there any plan to host that wheels? This could save some compile time.

This is possible but should be investigated. Feel free to ping me on Discord to discuss it, if you're interested on this topic.

misl6
misl6 reviewed May 4, 2024
View reviewed changes
Copy link
Member

@misl6 misl6 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had a first read, that's a super nice job, but let's try to slowly clean it up / document some changes.

Will apply kivy/kivy#8713 also on kivy/python-for-android today, so you'll have less things to worry about. (and CI will be faster, as more runners are available concurrently)

EDIT: Changes applied, you now have access to macos-13 (Intel) and macos-latest (Apple Silicon)

pythonforandroid/recipes/cppy/__init__.py Outdated Show resolved Hide resolved
pythonforandroid/recipes/kiwisolver/__init__.py Outdated Show resolved Hide resolved
@T-Dynamos T-Dynamos marked this pull request as draft May 4, 2024 12:45
@T-Dynamos T-Dynamos force-pushed the pandas-update branch 3 times, most recently from d543d42 to 3a72a20 Compare May 4, 2024 15:11
@T-Dynamos T-Dynamos marked this pull request as ready for review May 4, 2024 16:56
@T-Dynamos
Copy link
Contributor Author

@misl6 Done.

misl6
misl6 reviewed May 5, 2024
View reviewed changes
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another (great) step forward!

I've left a few comments around, can you please share your thoughts?

pythonforandroid/recipes/scipy/__init__.py Outdated Show resolved Hide resolved
pythonforandroid/recipes/numpy/__init__.py Outdated Show resolved Hide resolved
pythonforandroid/recipe.py Outdated Show resolved Hide resolved
pythonforandroid/recipe.py Outdated Show resolved Hide resolved
pythonforandroid/recipe.py Outdated Show resolved Hide resolved
pythonforandroid/recipe.py Outdated Show resolved Hide resolved
pythonforandroid/recipe.py Outdated Show resolved Hide resolved
pythonforandroid/recipe.py Outdated Show resolved Hide resolved
@misl6
Copy link
Member

misl6 commented May 5, 2024

Addition:

Here we need to inform the p4a users that if they are using numpy, they to set minimum ndk api to 24.

Maybe we can just raise an error if they try to do so ?

@T-Dynamos T-Dynamos marked this pull request as draft May 5, 2024 15:43
@T-Dynamos T-Dynamos marked this pull request as ready for review May 6, 2024 01:01
@T-Dynamos T-Dynamos requested a review from misl6 May 6, 2024 01:01
misl6
misl6 reviewed May 7, 2024
View reviewed changes
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we almost reached the final steps, let me know when you're ready for the last round!

pythonforandroid/recommendations.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
pythonforandroid/recipes/numpy/__init__.py Show resolved Hide resolved
wheels/kiwisolver-1.4.5-cp311-cp311-android_arm.whl Outdated Show resolved Hide resolved
misl6
misl6 approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 🎉

LGTM. Thank you!

@misl6 misl6 merged commit 87a32be into kivy:develop May 9, 2024
33 checks passed
This was referenced May 9, 2024
Closed
Closed
@T-Dynamos T-Dynamos mentioned this pull request May 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misl6 misl6 misl6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Pandas>=1.3.0. Ability to use newer version of pandas
2 participants
@T-Dynamos @misl6