Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recipes: add new grpcio recipe #3023

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

kengoon
Copy link
Contributor

@kengoon kengoon commented May 28, 2024

fix #2498

@T-Dynamos
Copy link
Contributor

@kengoon Hi!

Can we make this compatible with PyProjectRecipe?

@kengoon
Copy link
Contributor Author

kengoon commented May 28, 2024

@T-Dynamos how? is there a guide line? Grpcio does not make use of poetry

@misl6
Copy link
Member

misl6 commented May 29, 2024

Hi @kengoon,

Our CI/CD pipeline noticed something that should not happen while building the grpcio recipe.
BTW, better to ensure every new recipe build is isolated and performed via PyProjectRecipe as @T-Dynamos suggested.

Ping me when ready for the final review and a merge.

@kengoon
Copy link
Contributor Author

kengoon commented May 29, 2024

@misl6 PyPtojectReciepe requires pyproject.toml file right? I'm now asking how do I go about using that, the guidelines. Because grpcio does not use use pyproject.toml file

'''Recipe for projects which containes `pyproject.toml`'''

@misl6
Copy link
Member

misl6 commented May 29, 2024

@misl6 PyPtojectReciepe requires pyproject.toml file right? I'm now asking how do I go about using that, the guidelines. Because grpcio does not use use pyproject.toml file

Ouch, I see they have an issue opened for that.

@T-Dynamos , anything we can do on our side to have an isolated build without pyproject.toml ?

@T-Dynamos
Copy link
Contributor

T-Dynamos commented May 30, 2024

PyProjectRecipe support both build systems.

* Creating isolated environment: venv+pip...
ERROR Source /home/sompath does not appear to be a Python project: no pyproject.toml or setup.py

Also I have built this recipe locally with PyProjectRecipe and it works.

@kengoon
Copy link
Contributor Author

kengoon commented May 30, 2024

@T-Dynamos and @misl6 Alright I will see to it. @T-Dynamos can you share a copy of the changes you made to make it work with PyProject

@T-Dynamos
Copy link
Contributor

T-Dynamos commented May 30, 2024

@kengoon

Changes are in GitHub review.

@kengoon
Copy link
Contributor Author

kengoon commented May 30, 2024

@T-Dynamos I can't see any reviews here

@kengoon
Copy link
Contributor Author

kengoon commented May 31, 2024

@T-Dynamos thanks for your help with the guide on migrating to PyProjectRecipe

@kengoon
Copy link
Contributor Author

kengoon commented May 31, 2024

@misl6 a nice ping for you

@T-Dynamos
Copy link
Contributor

T-Dynamos commented Jun 1, 2024

@kengoon You forgot to include use-ndk-zlib-and-openssl-recipe-include.patch:

    patches = ["comment-getserverbyport-r-args.patch", "remove-android-log-write.patch"]

@kengoon
Copy link
Contributor Author

kengoon commented Jun 1, 2024

@T-Dynamos oh sh*t

@kengoon
Copy link
Contributor Author

kengoon commented Jun 2, 2024

@misl6 ready for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gRPC Recipe Error
3 participants