-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recipes: add new grpcio
recipe
#3023
base: develop
Are you sure you want to change the base?
Conversation
@kengoon Hi! Can we make this compatible with |
@T-Dynamos how? is there a guide line? Grpcio does not make use of poetry |
Hi @kengoon, Our CI/CD pipeline noticed something that should not happen while building the Ping me when ready for the final review and a merge. |
@misl6 PyPtojectReciepe requires pyproject.toml file right? I'm now asking how do I go about using that, the guidelines. Because grpcio does not use use pyproject.toml file python-for-android/pythonforandroid/recipe.py Line 1175 in 5dc17e1
|
Ouch, I see they have an issue opened for that. @T-Dynamos , anything we can do on our side to have an isolated build without |
Also I have built this recipe locally with |
@T-Dynamos and @misl6 Alright I will see to it. @T-Dynamos can you share a copy of the changes you made to make it work with PyProject |
Changes are in GitHub review. |
@T-Dynamos I can't see any reviews here |
@T-Dynamos thanks for your help with the guide on migrating to PyProjectRecipe |
@misl6 a nice ping for you |
@kengoon You forgot to include patches = ["comment-getserverbyport-r-args.patch", "remove-android-log-write.patch"] |
@T-Dynamos oh sh*t |
@misl6 ready for you |
fix #2498