Cannot jump to org entries from calfw using the keyboard

[tsdh]

When using calfw-org, you can jump to an org entry by clicking on the
corresponding calfw table entry using the mouse. In theory, you should be able
to do the same by hitting RET when point is on a calfw entry (see
cfw:org-text-keymap).

However, there is no way to set point on a calfw entry except by using the
mouse! All navigation keys (the arrow keys, C-n, C-p, C-f, C-p,...) navigate
by time units (next day, week, month,...), so you can't set point to one
appointment entry contained in some "day cell".

[kiwanami]

Thank you for your comment.

The current key binding of calfw is just my first idea and is not fixed.
I think we should try many patterns to make it more convenient.

Many calendar applications use the navigation keys to move the date focus, and it is intuitive.
But many Emacs users, including me, think navigation keys should move just the cursor position.
Designing the key binding, I have been bothered by this conflict.

In my idea, TAB key may navigates the focus of the items in the day cell.
I will try it soon.

If you have any idea, please let me know.

[tsdh]

kiwanami
reply@reply.github.com
writes:

Hi!

The current key binding of calfw is just my first idea and is not
fixed. I think we should try many patterns to make it more
convenient.

Many calendar applications use the navigation keys to move the date
focus, and it is intuitive. But many Emacs users, including me, think
navigation keys should move just the cursor position. Designing the
key binding, I have been bothered by this conflict.

In my idea, TAB key may navigates the focus of the items in the day
cell. I will try it soon.

TAB sounds good to jump from item to item. And maybe it would be good
to use C-n/C-p/C-f/C-b for moving point freely. Then you have item
based navigation using (TAB, and probably M-TAB to jump backwards), time
based navigation using the arrow keys, and free point motion using the
standard emacs keys.

Bye,
Tassilo

[tsdh]

Hi again,

I've changed the default bindings in order that C-n/C-p/C-f/C-b do normal point movement and added some alternatives to the time based navigation (n/p/f/b, and C-v/M-v for next/previous month). Feel free to pull commit e6ff593 from git://github.com/tsdh/emacs-calfw.git

Sorry, the patch is large because I've desperately ran M-x delete-trailing-whitespaces RET. Real code changes are only in the keymap definition.

Wow, github is really cool. If you click on the commit sha1 code you'll see the diff, and there I added a "line note". Just watch out for that.

[tsdh]

Sorry for that close-reopen-dance. I misinterpreted the button "Comment & Close" as "comment and return to the issues overview".

[kiwanami]

I implemented TAB navigation and pushed.
Will you try it?

[tsdh]

kiwanami
reply@reply.github.com
writes:

Hi Masashi,

I implemented TAB navigation and pushed.
Will you try it?

Sure. The TAB navigation works great. :-)

There's one regression, though. cfw:org-onclick jumps to the org entry,
but it doesn't expand the outline tree. So although point is at the
correct position, I cannot see the entry because the tree is collapsed.

I think, formerly it used to expand the complete org file. That wasn't
optimal either, but still better than to see nothing.

Bye,
Tassilo

[kiwanami]

Thanks for your comment.
I fixed jumping to folded items. Is it ok?

[tsdh]

kiwanami
reply@reply.github.com
writes:

Hi!

Thanks for your comment.
I fixed jumping to folded items. Is it ok?

Yes, now it's like it used to be. The complete tree is unfolded. It
would even be better if only the current context was unfolded. I think,
that's what

,----[ (info "(org)Visibility cycling") ]
| C-c C-r' (org-reveal')
| Reveal context around point, showing the current entry, the
| following heading and the hierarchy above. Useful for working
| near a location that has been exposed by a sparse tree command
| (_note Sparse trees::) or an agenda command (_note Agenda
| commands::). With a prefix argument show, on each level, all
| sibling headings. With double prefix arg, also show the entire
| subtree of the parent.
`----

does.

Sorry, I don't have time to test. My wife and me are going on a trip
the next two weeks. :-)

Bye,
Tassilo

[kiwanami]

Hi, Tassilo

I modified expanding function with org-reveal and pushed it.
I hope that it is what you intended.
If not, I will try again.

Thank you

[tsdh]

kiwanami
reply@reply.github.com
writes:

Hi!

I modified expanding function with org-reveal and pushed it.
I hope that it is what you intended.

That's exactly what I wanted. :-)

Thanks a lot,
Tassilo