Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Events from org-mode lasting for more than one day are shown correctly in blocks (#11) #60

Merged
merged 3 commits into from
May 4, 2015

Conversation

cbourjau
Copy link

Hello,
this pull request fixes the issue of calfw not recognizing events lasting for several days as reported in issue #11. The problem arose because org mode apparently changed its behaviour with the "dotime" property of the event. In order to fix this issue, I check if an event has the "extra" property set with a value of something like eg. "(1/3): ". This "extra" property give the information of which day you are in in a multi day event, here its day one of three. You can see this extra property in action when you look at a multi day event in the Agenda view.

Anyhow, I am rather new to elisp so comments and suggestions are very welcome! This fix works well for me and I hope some other people will find it useful too!

@cbourjau cbourjau changed the title works with none scheduled events FIX: Events from org-mode lasting for more than one day are shown correctly in blocks (#11) Apr 26, 2015
@kiwanami
Copy link
Owner

Hi, @ChrisBoo
Thank you for your PR!
I checked this patch solves the problem with a small test org file. It's great!
One thing, usually underscore is not used for symbol name in elisp. So, I prefer cur_day to cur-day.

@myuhe
Do you have some comment?

@cbourjau
Copy link
Author

ok, I changed the names and also made sure that dotime is actually a string

kiwanami added a commit that referenced this pull request May 4, 2015
FIX: Events from org-mode lasting for more than one day are shown correctly in blocks (#11)
@kiwanami kiwanami merged commit e00a060 into kiwanami:master May 4, 2015
@kiwanami
Copy link
Owner

kiwanami commented May 4, 2015

Merged.
Thank you!

@cbourjau
Copy link
Author

cbourjau commented May 4, 2015

My pleasure.

@myuhe
Copy link
Contributor

myuhe commented May 9, 2015

@ChrisBoo 's PR works fine on my environment.
Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants