Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Kiwi-iOS target to build for x86_64 and arm64 #455

Merged
merged 2 commits into from
Feb 24, 2014
Merged

Update the Kiwi-iOS target to build for x86_64 and arm64 #455

merged 2 commits into from
Feb 24, 2014

Conversation

jessedc
Copy link
Contributor

@jessedc jessedc commented Feb 19, 2014

make install will now build a fat library with all 5 iOS architectures, i386, x86_64, armv7, armv7s and arm64.

The Kiwi-iOS composite target needed to be updated to get the x86_64 target library build along side the others.

Building explicitly for the x86_64 simulator required a bit of trial and error, xcodebuild seems unable to build i386 and x86_64 at the same time, so I added step specifically for x86_64.

Restricting the VALID_ARCHS, ARCHS and IPHONEOS_DEPLOYMENT_TARGET for the 64bit simulator build seemed to do the trick.

ARCHS='x86_64' VALID_ARCHS='x86_64' IPHONEOS_DEPLOYMENT_TARGET='7.0'

The resulting library shows support for all 5 architectures:

xcrun -sdk iphoneos lipo -info libKiwi.a 
Architectures in the fat file: libKiwi.a are: i386 x86_64 armv7 armv7s arm64

Note There were also two header files that had been omitted from the Copy Files phase of the build.

Add KWNotificationMatcher.h to the ‘Copy Files’ build phase.
@jessedc
Copy link
Contributor Author

jessedc commented Feb 19, 2014

Travis has broken itself, it's failure on 0e2fc2d is in error.

@supermarin
Copy link

restarting the build

@supermarin
Copy link

Seems like a dns issue. let's try again tomorrow

@sync
Copy link

sync commented Feb 23, 2014

👍 would love to have this merged. thanks

supermarin pushed a commit that referenced this pull request Feb 24, 2014
Update the Kiwi-iOS target to build for x86_64 and arm64
@supermarin supermarin merged commit ac2cd41 into kiwi-bdd:master Feb 24, 2014
@jessedc jessedc deleted the 64bit-framework branch February 27, 2014 00:15
@BoneDesert
Copy link

I think that the file KWNotificationMatcher.h is also missing from the Kiwi-XCTest target as well. I can't use pods on my project and have used the instructions in the wiki to create a static library for the XCTest suite. When I attempt to run Tests in Xcode I'm getting the following : -

Lexical or Pre-Processor Issue 'KWNotificationMatcher.h'

Looking at the number of files in the copy phase for both Kiwi and Kiwi-XCTest targets they are 95 and 94 respectively.

Am I right or should I now be using some other build process documentation. Perhaps updating the wiki is the issue for XCTests ???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants