Skip to content

Commit

Permalink
Add minstep to aircon config (#570)
Browse files Browse the repository at this point in the history
  • Loading branch information
nasudon committed May 19, 2023
1 parent 2bca1e9 commit 9f13d01
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
3 changes: 2 additions & 1 deletion accessories/aircon.js
Expand Up @@ -62,6 +62,7 @@ class AirConAccessory extends BroadlinkRMAccessory {
if (config.minimumAutoOnOffDuration === undefined) {config.minimumAutoOnOffDuration = config.autoMinimumDuration || 120;} // Backwards compatible with `autoMinimumDuration`
config.minTemperature = config.minTemperature || -15;
config.maxTemperature = config.maxTemperature || 50;
config.minStep = config.minStep || 1;
if(config.mqttURL) {
//MQTT updates when published so frequent refreshes aren't required ( 10 minute default as a fallback )
config.temperatureUpdateFrequency = config.temperatureUpdateFrequency || 600;
Expand Down Expand Up @@ -866,7 +867,7 @@ class AirConAccessory extends BroadlinkRMAccessory {
.setProps({
minValue: config.minTemperature,
maxValue: config.maxTemperature,
minStep: 1
minStep: config.minStep
});

this.serviceManager
Expand Down
3 changes: 3 additions & 0 deletions test/airConditioner.test.js
Expand Up @@ -55,6 +55,7 @@ describe('airConAccessory', async () => {
expect(airConAccessory.config.minimumAutoOnOffDuration).to.equal(120);
expect(airConAccessory.config.minTemperature).to.equal(-15);
expect(airConAccessory.config.maxTemperature).to.equal(50);
expect(airConAccessory.config.minStep).to.equal(1);
expect(airConAccessory.config.units).to.equal('c');
expect(airConAccessory.config.temperatureUpdateFrequency).to.equal(10);
expect(airConAccessory.config.temperatureAdjustment).to.equal(0);
Expand All @@ -74,6 +75,7 @@ describe('airConAccessory', async () => {
minimumAutoOnOffDuration: 60,
minTemperature: 2,
maxTemperature: 36,
minStep: 0.5,
units: 'f',
temperatureUpdateFrequency: 20,
temperatureAdjustment: 1,
Expand All @@ -89,6 +91,7 @@ describe('airConAccessory', async () => {
expect(airConAccessory.config.minimumAutoOnOffDuration).to.equal(60);
expect(airConAccessory.config.minTemperature).to.equal(2);
expect(airConAccessory.config.maxTemperature).to.equal(36);
expect(airConAccessory.config.minStep).to.equal(0.5);
expect(airConAccessory.config.units).to.equal('f');
expect(airConAccessory.config.temperatureUpdateFrequency).to.equal(20);
expect(airConAccessory.config.temperatureAdjustment).to.equal(1);
Expand Down

0 comments on commit 9f13d01

Please sign in to comment.