Fix for wrong command being sent or no command sent in certain circumstances #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed errors in new fan.js (arp and setSwtichState) --------- Co-authored-by: Dave Nicolson <david.nicolson@gmail.com>
…stances This commit fixes two separate (but related) issues: 1. If resend is set to true and target position is equal to current position, the previous implementation resulted in sending the close command. That doesn't make sense - for example, if the window covering is already completely open, the previous implementation made it close instead of keeping it open. 2. If close->open commands are issued in rapid succession, the open command will not get sent because the target position is still equal to current position. This is not really true in reality since the window covering has already started moving by then. The previous implementation resulted in the window covering continuing to close, rather then start opening.
|
@kiwi-cam might taking a look? Thanks |
|
? |
|
@kiwi-cam, could this please be merged? thanks |
|
Anyone there? |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes two separate (but related) issues:
That doesn't make sense - for example, if the window covering is already completely open, the previous implementation made it close instead of keeping it open.