Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Collapse component #381

Merged
merged 11 commits into from
Mar 27, 2023
Merged

Add Collapse component #381

merged 11 commits into from
Mar 27, 2023

Conversation

yveskalume
Copy link
Contributor

closes #348

@yveskalume yveskalume requested a review from a team as a code owner March 22, 2023 09:42
@yveskalume yveskalume marked this pull request as draft March 22, 2023 09:43
@yveskalume yveskalume changed the title add Collapse Component add Collapse Component Mar 22, 2023
@hrach hrach added feature New feature or request new component labels Mar 22, 2023
@hrach hrach changed the title add Collapse Component Add Collapse Component Mar 22, 2023
@yveskalume yveskalume marked this pull request as ready for review March 22, 2023 18:03
hrach
hrach suggested changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@hrach hrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution. Good job 👍 Just a few naming things and the semantics custom action to fix.

Maybe you could use our CustomPlaceholder() helper to visualize it with the green box in the preview/screenshot.

ui/src/main/java/kiwi/orbit/compose/ui/controls/Collapse.kt Outdated Show resolved Hide resolved
ui/src/main/java/kiwi/orbit/compose/ui/controls/Collapse.kt Outdated Show resolved Hide resolved
ui/src/main/java/kiwi/orbit/compose/ui/controls/Collapse.kt Outdated Show resolved Hide resolved
ui/src/main/java/kiwi/orbit/compose/ui/controls/Collapse.kt Outdated Show resolved Hide resolved
ui/src/main/java/kiwi/orbit/compose/ui/controls/Collapse.kt Outdated Show resolved Hide resolved
ui/src/main/java/kiwi/orbit/compose/ui/controls/Collapse.kt Outdated Show resolved Hide resolved
ui/src/main/java/kiwi/orbit/compose/ui/controls/Collapse.kt Outdated Show resolved Hide resolved
Drekorian
Drekorian suggested changes Mar 23, 2023
View reviewed changes
docs/03-components/07-interaction/collapse.mdx Outdated Show resolved Hide resolved
docs/03-components/07-interaction/collapse.mdx Outdated Show resolved Hide resolved
docs/03-components/07-interaction/collapse.mdx Outdated Show resolved Hide resolved
docs/03-components/07-interaction/collapse.mdx Outdated Show resolved Hide resolved
ui/src/test/kotlin/kiwi/orbit/compose/ui/controls/CollapseTest.kt Outdated Show resolved Hide resolved
@yveskalume yveskalume requested review from Drekorian and hrach and removed request for Drekorian and hrach March 25, 2023 06:39
hrach
hrach approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@hrach hrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution. We're going to merge it.

Though we're still discussing some API changes, we will probably revert to your original name onExpandChange and create a custom semantics action to expose those expand/collapse actions and the current state.

@hrach hrach merged commit ba10d99 into kiwicom:main Mar 27, 2023
@hrach hrach changed the title Add Collapse Component Add Collapse component Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drekorian Drekorian Drekorian approved these changes

@hrach hrach hrach approved these changes

Assignees
No one assigned
Labels
feature New feature or request new component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Collapse component
3 participants
@yveskalume @Drekorian @hrach