Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to define custom switch icons #563

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Add option to define custom switch icons #563

merged 1 commit into from
Oct 26, 2023

Conversation

shanio
Copy link
Member

@shanio shanio commented Oct 20, 2023

No description provided.

@shanio shanio self-assigned this Oct 20, 2023
@shanio shanio linked an issue Oct 20, 2023 that may be closed by this pull request
Allow changing Switch's icon #529
Closed
@shanio shanio force-pushed the feature/switch_custom_painter branch from 468a1e4 to 5033826 Compare October 20, 2023 15:20
@hrach hrach added the feature New feature or request label Oct 23, 2023
@shanio shanio force-pushed the feature/switch_custom_painter branch from 5033826 to 4fa62ec Compare October 25, 2023 15:25
@shanio shanio marked this pull request as ready for review October 25, 2023 15:26
@shanio shanio requested a review from a team as a code owner October 25, 2023 15:26
hrach
hrach approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@hrach hrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a different icon to the preview to have it screenshot with e.g. lock? :)

@shanio
Copy link
Member Author

shanio commented Oct 26, 2023

Could you please add a different icon to the preview to have it screenshot with e.g. lock? :)

Sure thing. Wanted to point out that screenshot test did not notice the change on circle icon.

@shanio shanio force-pushed the feature/switch_custom_painter branch from 4fa62ec to 44f2c3e Compare October 26, 2023 13:38
@shanio shanio force-pushed the feature/switch_custom_painter branch from 44f2c3e to 9a96f85 Compare October 26, 2023 15:13
@shanio shanio enabled auto-merge October 26, 2023 15:14
@shanio shanio merged commit 33dd310 into main Oct 26, 2023
1 check passed
@shanio shanio deleted the feature/switch_custom_painter branch October 26, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drekorian Drekorian Drekorian approved these changes

@hrach hrach hrach approved these changes

Assignees

@shanio shanio

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow changing Switch's icon
3 participants
@shanio @Drekorian @hrach