New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Heading and Icon concatenation support #276
Add Heading and Icon concatenation support #276
Conversation
Sources/Orbit/Support/TextConcatenation/SwiftUITextRepresentable+Concatenation.swift
Outdated
Show resolved
Hide resolved
Sources/Orbit/Support/TextConcatenation/TextRepresentable.swift
Outdated
Show resolved
Hide resolved
Sources/Orbit/Support/TextConcatenation/DynamicTextWrapper.swift
Outdated
Show resolved
Hide resolved
Thinking about it more, do we even need the wrapper? We could make a generic |
We need a wrapper, that is a view because that seems to be the only way to pass I am not 100% sure but it seems to me that later we could replace |
Hmm that's quite a lot of failures 🤔 No idea how to trigger a manual job on a fork though... |
Sources/Orbit/Support/TextConcatenation/DynamicTextWrapper.swift
Outdated
Show resolved
Hide resolved
Sources/Orbit/Support/TextConcatenation/SwiftUITextRepresentable+Concatenation.swift
Outdated
Show resolved
Hide resolved
Sources/Orbit/Support/TextConcatenation/SwiftUITextRepresentable+Concatenation.swift
Outdated
Show resolved
Hide resolved
Sources/Orbit/Support/TextConcatenation/TextRepresentable.swift
Outdated
Show resolved
Hide resolved
@sjavora @bul-nick-al it should be available for running from the fork repo |
@PavelHolec nope. At least not for me. |
Thats because the repo owner has to first accept the workflows. And even then, it could be that only the author can see them (could also depend on the forked repo settings) |
Add the ability to concatenate
Icon
andHeading
of various styles in any order. Inspired by How to insert images into text.This addition will allow us to create layouts with text akin to this