fix(Stack): remove height: 100% for justify and column

kiwicom · Nov 25, 2023 · c119130 · c119130
1 parent 3b49d18
commit c119130
Show file tree

Hide file tree

Showing 51 changed files with 0 additions and 1 deletion.
diff --git a/...isual-Stack-Stack-with-justify-around-and-direction-column-1-Desktop-darwin.png b/...isual-Stack-Stack-with-justify-around-and-direction-column-1-Desktop-darwin.png
diff --git a/...visual-Stack-Stack-with-justify-around-and-direction-column-1-Desktop-linux.png b/...visual-Stack-Stack-with-justify-around-and-direction-column-1-Desktop-linux.png
diff --git a/...Stack-Stack-with-justify-around-and-direction-column-1-Large-Desktop-darwin.png b/...Stack-Stack-with-justify-around-and-direction-column-1-Large-Desktop-darwin.png
diff --git a/...-Stack-Stack-with-justify-around-and-direction-column-1-Large-Desktop-linux.png b/...-Stack-Stack-with-justify-around-and-direction-column-1-Large-Desktop-linux.png
diff --git a/...-Stack-Stack-with-justify-around-and-direction-column-1-Large-Mobile-darwin.png b/...-Stack-Stack-with-justify-around-and-direction-column-1-Large-Mobile-darwin.png
diff --git a/...l-Stack-Stack-with-justify-around-and-direction-column-1-Large-Mobile-linux.png b/...l-Stack-Stack-with-justify-around-and-direction-column-1-Large-Mobile-linux.png
diff --git a/...Stack-Stack-with-justify-around-and-direction-column-1-Medium-Mobile-darwin.png b/...Stack-Stack-with-justify-around-and-direction-column-1-Medium-Mobile-darwin.png
diff --git a/...-Stack-Stack-with-justify-around-and-direction-column-1-Medium-Mobile-linux.png b/...-Stack-Stack-with-justify-around-and-direction-column-1-Medium-Mobile-linux.png
diff --git a/...-Stack-Stack-with-justify-around-and-direction-column-1-Small-Mobile-darwin.png b/...-Stack-Stack-with-justify-around-and-direction-column-1-Small-Mobile-darwin.png
diff --git a/...l-Stack-Stack-with-justify-around-and-direction-column-1-Small-Mobile-linux.png b/...l-Stack-Stack-with-justify-around-and-direction-column-1-Small-Mobile-linux.png
diff --git a/...visual-Stack-Stack-with-justify-around-and-direction-column-1-Tablet-darwin.png b/...visual-Stack-Stack-with-justify-around-and-direction-column-1-Tablet-darwin.png
diff --git a/.../visual-Stack-Stack-with-justify-around-and-direction-column-1-Tablet-linux.png b/.../visual-Stack-Stack-with-justify-around-and-direction-column-1-Tablet-linux.png
diff --git a/...sual-Stack-Stack-with-justify-between-and-direction-column-1-Desktop-darwin.png b/...sual-Stack-Stack-with-justify-between-and-direction-column-1-Desktop-darwin.png
diff --git a/...isual-Stack-Stack-with-justify-between-and-direction-column-1-Desktop-linux.png b/...isual-Stack-Stack-with-justify-between-and-direction-column-1-Desktop-linux.png
diff --git a/...tack-Stack-with-justify-between-and-direction-column-1-Large-Desktop-darwin.png b/...tack-Stack-with-justify-between-and-direction-column-1-Large-Desktop-darwin.png
diff --git a/...Stack-Stack-with-justify-between-and-direction-column-1-Large-Desktop-linux.png b/...Stack-Stack-with-justify-between-and-direction-column-1-Large-Desktop-linux.png
diff --git a/...Stack-Stack-with-justify-between-and-direction-column-1-Large-Mobile-darwin.png b/...Stack-Stack-with-justify-between-and-direction-column-1-Large-Mobile-darwin.png
diff --git a/...-Stack-Stack-with-justify-between-and-direction-column-1-Large-Mobile-linux.png b/...-Stack-Stack-with-justify-between-and-direction-column-1-Large-Mobile-linux.png
diff --git a/...tack-Stack-with-justify-between-and-direction-column-1-Medium-Mobile-darwin.png b/...tack-Stack-with-justify-between-and-direction-column-1-Medium-Mobile-darwin.png
diff --git a/...Stack-Stack-with-justify-between-and-direction-column-1-Medium-Mobile-linux.png b/...Stack-Stack-with-justify-between-and-direction-column-1-Medium-Mobile-linux.png
diff --git a/...Stack-Stack-with-justify-between-and-direction-column-1-Small-Mobile-darwin.png b/...Stack-Stack-with-justify-between-and-direction-column-1-Small-Mobile-darwin.png
diff --git a/...-Stack-Stack-with-justify-between-and-direction-column-1-Small-Mobile-linux.png b/...-Stack-Stack-with-justify-between-and-direction-column-1-Small-Mobile-linux.png
diff --git a/...isual-Stack-Stack-with-justify-between-and-direction-column-1-Tablet-darwin.png b/...isual-Stack-Stack-with-justify-between-and-direction-column-1-Tablet-darwin.png
diff --git a/...visual-Stack-Stack-with-justify-between-and-direction-column-1-Tablet-linux.png b/...visual-Stack-Stack-with-justify-between-and-direction-column-1-Tablet-linux.png
diff --git a/...isual-Stack-Stack-with-justify-center-and-direction-column-1-Desktop-darwin.png b/...isual-Stack-Stack-with-justify-center-and-direction-column-1-Desktop-darwin.png
diff --git a/...visual-Stack-Stack-with-justify-center-and-direction-column-1-Desktop-linux.png b/...visual-Stack-Stack-with-justify-center-and-direction-column-1-Desktop-linux.png
diff --git a/...Stack-Stack-with-justify-center-and-direction-column-1-Large-Desktop-darwin.png b/...Stack-Stack-with-justify-center-and-direction-column-1-Large-Desktop-darwin.png
diff --git a/...-Stack-Stack-with-justify-center-and-direction-column-1-Large-Desktop-linux.png b/...-Stack-Stack-with-justify-center-and-direction-column-1-Large-Desktop-linux.png
diff --git a/...-Stack-Stack-with-justify-center-and-direction-column-1-Large-Mobile-darwin.png b/...-Stack-Stack-with-justify-center-and-direction-column-1-Large-Mobile-darwin.png
diff --git a/...l-Stack-Stack-with-justify-center-and-direction-column-1-Large-Mobile-linux.png b/...l-Stack-Stack-with-justify-center-and-direction-column-1-Large-Mobile-linux.png
diff --git a/...Stack-Stack-with-justify-center-and-direction-column-1-Medium-Mobile-darwin.png b/...Stack-Stack-with-justify-center-and-direction-column-1-Medium-Mobile-darwin.png
diff --git a/...-Stack-Stack-with-justify-center-and-direction-column-1-Medium-Mobile-linux.png b/...-Stack-Stack-with-justify-center-and-direction-column-1-Medium-Mobile-linux.png
diff --git a/...-Stack-Stack-with-justify-center-and-direction-column-1-Small-Mobile-darwin.png b/...-Stack-Stack-with-justify-center-and-direction-column-1-Small-Mobile-darwin.png
diff --git a/...l-Stack-Stack-with-justify-center-and-direction-column-1-Small-Mobile-linux.png b/...l-Stack-Stack-with-justify-center-and-direction-column-1-Small-Mobile-linux.png
diff --git a/...visual-Stack-Stack-with-justify-center-and-direction-column-1-Tablet-darwin.png b/...visual-Stack-Stack-with-justify-center-and-direction-column-1-Tablet-darwin.png
diff --git a/.../visual-Stack-Stack-with-justify-center-and-direction-column-1-Tablet-linux.png b/.../visual-Stack-Stack-with-justify-center-and-direction-column-1-Tablet-linux.png
diff --git a/...s/visual-Stack-Stack-with-justify-center-and-direction-row-1-Desktop-darwin.png b/...s/visual-Stack-Stack-with-justify-center-and-direction-row-1-Desktop-darwin.png
diff --git a/...al-Stack-Stack-with-justify-center-and-direction-row-1-Large-Desktop-darwin.png b/...al-Stack-Stack-with-justify-center-and-direction-row-1-Large-Desktop-darwin.png
diff --git a/...s/visual-Stack-Stack-with-justify-end-and-direction-column-1-Desktop-darwin.png b/...s/visual-Stack-Stack-with-justify-end-and-direction-column-1-Desktop-darwin.png
diff --git a/...ts/visual-Stack-Stack-with-justify-end-and-direction-column-1-Desktop-linux.png b/...ts/visual-Stack-Stack-with-justify-end-and-direction-column-1-Desktop-linux.png
diff --git a/...al-Stack-Stack-with-justify-end-and-direction-column-1-Large-Desktop-darwin.png b/...al-Stack-Stack-with-justify-end-and-direction-column-1-Large-Desktop-darwin.png
diff --git a/...ual-Stack-Stack-with-justify-end-and-direction-column-1-Large-Desktop-linux.png b/...ual-Stack-Stack-with-justify-end-and-direction-column-1-Large-Desktop-linux.png
diff --git a/...ual-Stack-Stack-with-justify-end-and-direction-column-1-Large-Mobile-darwin.png b/...ual-Stack-Stack-with-justify-end-and-direction-column-1-Large-Mobile-darwin.png
diff --git a/...sual-Stack-Stack-with-justify-end-and-direction-column-1-Large-Mobile-linux.png b/...sual-Stack-Stack-with-justify-end-and-direction-column-1-Large-Mobile-linux.png
diff --git a/...al-Stack-Stack-with-justify-end-and-direction-column-1-Medium-Mobile-darwin.png b/...al-Stack-Stack-with-justify-end-and-direction-column-1-Medium-Mobile-darwin.png
diff --git a/...ual-Stack-Stack-with-justify-end-and-direction-column-1-Medium-Mobile-linux.png b/...ual-Stack-Stack-with-justify-end-and-direction-column-1-Medium-Mobile-linux.png
diff --git a/...ual-Stack-Stack-with-justify-end-and-direction-column-1-Small-Mobile-darwin.png b/...ual-Stack-Stack-with-justify-end-and-direction-column-1-Small-Mobile-darwin.png
diff --git a/...sual-Stack-Stack-with-justify-end-and-direction-column-1-Small-Mobile-linux.png b/...sual-Stack-Stack-with-justify-end-and-direction-column-1-Small-Mobile-linux.png
diff --git a/...ts/visual-Stack-Stack-with-justify-end-and-direction-column-1-Tablet-darwin.png b/...ts/visual-Stack-Stack-with-justify-end-and-direction-column-1-Tablet-darwin.png
diff --git a/...ots/visual-Stack-Stack-with-justify-end-and-direction-column-1-Tablet-linux.png b/...ots/visual-Stack-Stack-with-justify-end-and-direction-column-1-Tablet-linux.png
diff --git a/packages/orbit-components/src/Stack/index.tsx b/packages/orbit-components/src/Stack/index.tsx
@@ -151,7 +151,6 @@ const Stack = (props: Props) => {
       flex || inline ? getDisplayClasses(inline ? "inline-flex" : "flex", viewport) : "block",
       getSpacingClasses(spacing, viewport, direction, legacy),
       inline === false && "w-full",
-      !inline && direction === DIRECTION.COLUMN && "h-full",
     );
   };