feat(Select): Add optional key to Option (#1708)

kiwicom · Mar 24, 2020 · f824d4a · f824d4a
1 parent 33a9474
commit f824d4a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/src/Select/index.js b/src/Select/index.js
@@ -330,7 +330,11 @@ const Select = React.forwardRef<Props, HTMLElement>((props, ref) => {
             </option>
           )}
           {options.map(option => (
-            <option key={`option-${option.value}`} value={option.value} disabled={option.disabled}>
+            <option
+              key={`option-${option.key || option.value}`}
+              value={option.value}
+              disabled={option.disabled}
+            >
               {option.label}
             </option>
           ))}

diff --git a/src/Select/index.js.flow b/src/Select/index.js.flow
@@ -14,6 +14,7 @@ import type {
 import type { spaceAfter } from "../common/getSpacingToken/index";
 
 type Option = {|
+  +key?: string,
   +value: string | number,
   +label?: string,
   +disabled?: boolean,

diff --git a/src/SkipNavigation/index.js.flow b/src/SkipNavigation/index.js.flow
@@ -10,6 +10,7 @@ type Actions = {|
 |};
 
 export type MappedOptions = {|
+  +key?: string,
   +value: string | number,
   +label?: string,
   +disabled?: boolean,