-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(InputFile): forward onFocus event handler #2461
Conversation
Size Change: +5 B (0%) Total Size: 438 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was a mistake, probably. However I don't believe that someone is relying on this behavior – it doesn't make sense and in 99.9 % of cases you will handle just the onChange
.
7bea1cd
to
97eea7e
Compare
97eea7e
to
f251627
Compare
Ok, I edited the commit message to remove the breaking change status, because it's a bug fix. |
Focusing the input was previously triggering the
onChange
event handler, nowonFocus
is properly being forwarded. This should not be a problem, but is technically breaking for anyone that was relying on this behavior.This behavior was there from the beginning, I assume it's a mistake because the component takes
onFocus
which it doesn't use.LiveURL: https://orbit-fix-input-file-onFocus.surge.sh